Skip to content

Resolve wasm base path via module resolution - #159

Merged
davidjgoss merged 2 commits into
mainfrom
wasm-base-path
Nov 5, 2026
Merged

davidjgoss merged 2 commits into
mainfrom
wasm-base-path

Conversation

@davidjgoss

@davidjgoss davidjgoss commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

🤔 What's changed?

The standalone bin now finds the .wasm files in the language-service package with import.meta.resolve rather than hand-crafting a path. The resolved entry point is dist/index.js, so its directory is the dist folder that holds the wasm files.

⚡️ What's your motivation?

The server failed to start when npm (or other package manager) hoisted @cucumber/language-service.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@davidjgoss
davidjgoss marked this pull request as ready for review November 5, 2026 18:27
@davidjgoss
davidjgoss merged commit 6037672 into main Nov 5, 2026
12 checks passed
@davidjgoss
davidjgoss deleted the wasm-base-path branch November 5, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant