Skip to content

🛡️ Sentinel: Fix action checkout version and sanitize greeting name input#118

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
jules-5588907505831844835-de13f412
Closed

🛡️ Sentinel: Fix action checkout version and sanitize greeting name input#118
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
jules-5588907505831844835-de13f412

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This PR adds secure name input trimming and fallback in the greeting command to prevent blank or output-spoofing greetings. It also fixes a critical configuration error in the CI/CD workflows where a non-existent checkout action version (actions/checkout@v7) was called, correcting it to @v4 for stability and security. Corresponding unit tests and the Sentinel security journal have been added.


PR created automatically by Jules for task 5588907505831844835 started by @amrabed

- Strip leading/trailing whitespace from the name input in `project/app.py` and fallback to "World" if empty to avoid blank or output-spoofing greetings.
- Correct checkout action version from non-existent `@v7` to `@v4` in `.github/workflows/check.yml` and `.github/workflows/docs.yml` to stabilize CI/CD.
- Add unit tests in `tests/test_app.py` to cover name trimming and empty input fallback, and resolve pytest.main namespace collision using importing/aliasing conventions.
- Add the Sentinel Security Journal.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

Copy link
Copy Markdown

@amrabed amrabed closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant