Skip to content

Updates scope facets for enum constructor definitions from enum to enumConstant #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasArvidsson merged 2 commits into from
Sep 21, 2026
Merged

Updates scope facets for enum constructor definitions from enum to enumConstant #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
051dc1d
Updates scope facets for enum constructor definitions from `enum` to …
AndreasArvidsson Sep 21, 2026
03dbf1a
Description update
AndreasArvidsson Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions packages/app-web-docs/src/docs/user/languages/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,23 +47,23 @@ Below are visualizations of all our scope tests for this language. These were cr

<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.empty" languageId="dart" />

#### 5. Argument list: Actual enum empty
#### 5. Argument list: Actual enum constant empty

<i>An empty list of arguments in an enum constructor call. Insertion delimiter should be empty.</i>
<i>An empty parenthesized list in an enum constant or variant declaration. Insertion delimiter should be empty.</i>

<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.enum.empty" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.enumConstant.empty" languageId="dart" />

#### 6. Argument list: Actual enum multi line
#### 6. Argument list: Actual enum constant multi line

<i>A multi-line list of arguments in an enum constructor call. Insertion delimiter should include a newline.</i>
<i>A multi-line parenthesized list in an enum constant or variant declaration. Insertion delimiter should include a newline.</i>

<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.enum.multiLine" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.enumConstant.multiLine" languageId="dart" />

#### 7. Argument list: Actual enum single line
#### 7. Argument list: Actual enum constant single line

<i>A single-line list of arguments in an enum constructor call</i>
<i>A single-line parenthesized list in an enum constant or variant declaration</i>

<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.enum.singleLine" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/argumentList/argumentList.actual.enumConstant.singleLine" languageId="dart" />

#### 8. Argument list: Actual method empty

Expand Down Expand Up @@ -181,17 +181,17 @@ Below are visualizations of all our scope tests for this language. These were cr

<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.constructor.singleLine" languageId="dart" />

#### 3. Argument: Actual enum multi line
#### 3. Argument: Actual enum constant multi line

<i>A multi-line argument in an enum constructor call. Insertion delimiter should include a newline.</i>
<i>A multi-line argument in a parenthesized enum constant or variant declaration. Insertion delimiter should include a newline.</i>

<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.enum.multiLine" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.enumConstant.multiLine" languageId="dart" />

#### 4. Argument: Actual enum single line
#### 4. Argument: Actual enum constant single line

<i>A single-line argument in an enum constructor call</i>
<i>A single-line argument in a parenthesized enum constant or variant declaration</i>

<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.enum.singleLine" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.enumConstant.singleLine" languageId="dart" />

#### 5. Argument: Actual method multi line

Expand Down Expand Up @@ -283,11 +283,11 @@ Below are visualizations of all our scope tests for this language. These were cr

<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.constructor.iteration" languageId="dart" />

#### 20. Argument: Actual enum (iteration)
#### 20. Argument: Actual enum constant (iteration)

<i>Iteration scope for arguments in an enum constructor call: the argument list. The domain should be the entire enum constructor call..</i>
<i>Iteration scope for arguments in a parenthesized enum constant or variant declaration: the parenthesized list. The domain should be the entire enum constant or variant declaration..</i>

<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.enum.iteration" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/argument/argument.actual.enumConstant.iteration" languageId="dart" />

#### 21. Argument: Actual method (iteration)

Expand Down Expand Up @@ -509,11 +509,11 @@ Below are visualizations of all our scope tests for this language. These were cr

<ScopeVisualizer fixtureName="scopes/dart/functionCall/functionCall.constructor" languageId="dart" />

#### 4. Function call: Enum
#### 4. Function call: Enum constant

<i>An enum constructor call</i>
<i>An enum constant or variant declaration with parentheses</i>

<ScopeVisualizer fixtureName="scopes/dart/functionCall/functionCall.enum" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/functionCall/functionCall.enumConstant" languageId="dart" />

#### 5. Function call: Generic

Expand Down Expand Up @@ -547,11 +547,11 @@ Below are visualizations of all our scope tests for this language. These were cr

<ScopeVisualizer fixtureName="scopes/dart/functionCallee/functionCallee.constructor" languageId="dart" />

#### 4. Function callee: Enum
#### 4. Function callee: Enum constant

<i>The enum constructor being called</i>
<i>The name of an enum constant or variant declared with parentheses</i>

<ScopeVisualizer fixtureName="scopes/dart/functionCallee/functionCallee.enum" languageId="dart" />
<ScopeVisualizer fixtureName="scopes/dart/functionCallee/functionCallee.enumConstant" languageId="dart" />

#### 5. Function callee: Generic

Expand Down
32 changes: 16 additions & 16 deletions packages/app-web-docs/src/docs/user/languages/fixtures/dart.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
]
},
{
"name": "scopes/dart/argument/argument.actual.enum.iteration",
"name": "scopes/dart/argument/argument.actual.enumConstant.iteration",
"languageId": "dart",
"facet": "argument.actual.enum.iteration",
"facet": "argument.actual.enumConstant.iteration",
"code": "enum Foo {\n bar(aaa, bbb);\n}",
"scopes": [
{
Expand All @@ -118,9 +118,9 @@
]
},
{
"name": "scopes/dart/argument/argument.actual.enum.multiLine",
"name": "scopes/dart/argument/argument.actual.enumConstant.multiLine",
"languageId": "dart",
"facet": "argument.actual.enum.multiLine",
"facet": "argument.actual.enumConstant.multiLine",
"code": "enum Foo {\n bar(\n aaa,\n bbb\n );\n}",
"scopes": [
{
Expand All @@ -144,9 +144,9 @@
]
},
{
"name": "scopes/dart/argument/argument.actual.enum.singleLine",
"name": "scopes/dart/argument/argument.actual.enumConstant.singleLine",
"languageId": "dart",
"facet": "argument.actual.enum.singleLine",
"facet": "argument.actual.enumConstant.singleLine",
"code": "enum Foo {\n bar(aaa, bbb);\n}",
"scopes": [
{
Expand Down Expand Up @@ -672,9 +672,9 @@
]
},
{
"name": "scopes/dart/argumentList/argumentList.actual.enum.empty",
"name": "scopes/dart/argumentList/argumentList.actual.enumConstant.empty",
"languageId": "dart",
"facet": "argumentList.actual.enum.empty",
"facet": "argumentList.actual.enumConstant.empty",
"code": "enum Foo {\n bar();\n}",
"scopes": [
{
Expand All @@ -689,9 +689,9 @@
]
},
{
"name": "scopes/dart/argumentList/argumentList.actual.enum.multiLine",
"name": "scopes/dart/argumentList/argumentList.actual.enumConstant.multiLine",
"languageId": "dart",
"facet": "argumentList.actual.enum.multiLine",
"facet": "argumentList.actual.enumConstant.multiLine",
"code": "enum Foo {\n bar(\n aaa,\n bbb\n );\n}",
"scopes": [
{
Expand All @@ -706,9 +706,9 @@
]
},
{
"name": "scopes/dart/argumentList/argumentList.actual.enum.singleLine",
"name": "scopes/dart/argumentList/argumentList.actual.enumConstant.singleLine",
"languageId": "dart",
"facet": "argumentList.actual.enum.singleLine",
"facet": "argumentList.actual.enumConstant.singleLine",
"code": "enum Foo {\n bar(aaa, bbb);\n}",
"scopes": [
{
Expand Down Expand Up @@ -1700,9 +1700,9 @@
]
},
{
"name": "scopes/dart/functionCall/functionCall.enum",
"name": "scopes/dart/functionCall/functionCall.enumConstant",
"languageId": "dart",
"facet": "functionCall.enum",
"facet": "functionCall.enumConstant",
"code": "enum Foo {\n bar();\n}",
"scopes": [
{
Expand Down Expand Up @@ -1811,9 +1811,9 @@
]
},
{
"name": "scopes/dart/functionCallee/functionCallee.enum",
"name": "scopes/dart/functionCallee/functionCallee.enumConstant",
"languageId": "dart",
"facet": "functionCallee.enum",
"facet": "functionCallee.enumConstant",
"code": "enum Foo {\n bar();\n}",
"scopes": [
{
Expand Down
32 changes: 16 additions & 16 deletions packages/app-web-docs/src/docs/user/languages/fixtures/java.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
]
},
{
"name": "scopes/java/argument/argument.actual.enum.iteration",
"name": "scopes/java/argument/argument.actual.enumConstant.iteration",
"languageId": "java",
"facet": "argument.actual.enum.iteration",
"facet": "argument.actual.enumConstant.iteration",
"code": "enum Foo {\n bar(aaa, bbb);\n}",
"scopes": [
{
Expand All @@ -118,9 +118,9 @@
]
},
{
"name": "scopes/java/argument/argument.actual.enum.multiLine",
"name": "scopes/java/argument/argument.actual.enumConstant.multiLine",
"languageId": "java",
"facet": "argument.actual.enum.multiLine",
"facet": "argument.actual.enumConstant.multiLine",
"code": "enum Foo {\n bar(\n aaa,\n bbb\n );\n}",
"scopes": [
{
Expand All @@ -144,9 +144,9 @@
]
},
{
"name": "scopes/java/argument/argument.actual.enum.singleLine",
"name": "scopes/java/argument/argument.actual.enumConstant.singleLine",
"languageId": "java",
"facet": "argument.actual.enum.singleLine",
"facet": "argument.actual.enumConstant.singleLine",
"code": "enum Foo {\n bar(aaa, bbb);\n}",
"scopes": [
{
Expand Down Expand Up @@ -604,9 +604,9 @@
]
},
{
"name": "scopes/java/argumentList/argumentList.actual.enum.empty",
"name": "scopes/java/argumentList/argumentList.actual.enumConstant.empty",
"languageId": "java",
"facet": "argumentList.actual.enum.empty",
"facet": "argumentList.actual.enumConstant.empty",
"code": "enum Foo {\n bar();\n}",
"scopes": [
{
Expand All @@ -621,9 +621,9 @@
]
},
{
"name": "scopes/java/argumentList/argumentList.actual.enum.multiLine",
"name": "scopes/java/argumentList/argumentList.actual.enumConstant.multiLine",
"languageId": "java",
"facet": "argumentList.actual.enum.multiLine",
"facet": "argumentList.actual.enumConstant.multiLine",
"code": "enum Foo {\n bar(\n aaa,\n bbb\n );\n}",
"scopes": [
{
Expand All @@ -638,9 +638,9 @@
]
},
{
"name": "scopes/java/argumentList/argumentList.actual.enum.singleLine",
"name": "scopes/java/argumentList/argumentList.actual.enumConstant.singleLine",
"languageId": "java",
"facet": "argumentList.actual.enum.singleLine",
"facet": "argumentList.actual.enumConstant.singleLine",
"code": "enum Foo {\n bar(aaa, bbb);\n}",
"scopes": [
{
Expand Down Expand Up @@ -2154,9 +2154,9 @@
]
},
{
"name": "scopes/java/functionCall/functionCall.enum",
"name": "scopes/java/functionCall/functionCall.enumConstant",
"languageId": "java",
"facet": "functionCall.enum",
"facet": "functionCall.enumConstant",
"code": "enum Foo {\n bar();\n}",
"scopes": [
{
Expand Down Expand Up @@ -2265,9 +2265,9 @@
]
},
{
"name": "scopes/java/functionCallee/functionCallee.enum",
"name": "scopes/java/functionCallee/functionCallee.enumConstant",
"languageId": "java",
"facet": "functionCallee.enum",
"facet": "functionCallee.enumConstant",
"code": "enum Foo {\n bar();\n}",
"scopes": [
{
Expand Down
32 changes: 16 additions & 16 deletions packages/app-web-docs/src/docs/user/languages/fixtures/kotlin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@
]
},
{
"name": "scopes/kotlin/argument/argument.actual.enum.iteration",
"name": "scopes/kotlin/argument/argument.actual.enumConstant.iteration",
"languageId": "kotlin",
"facet": "argument.actual.enum.iteration",
"facet": "argument.actual.enumConstant.iteration",
"code": "enum class Foo {\n bar(aaa, bbb)\n}",
"scopes": [
{
Expand All @@ -186,9 +186,9 @@
]
},
{
"name": "scopes/kotlin/argument/argument.actual.enum.multiLine",
"name": "scopes/kotlin/argument/argument.actual.enumConstant.multiLine",
"languageId": "kotlin",
"facet": "argument.actual.enum.multiLine",
"facet": "argument.actual.enumConstant.multiLine",
"code": "enum class Foo {\n bar(\n aaa,\n bbb\n )\n}",
"scopes": [
{
Expand All @@ -212,9 +212,9 @@
]
},
{
"name": "scopes/kotlin/argument/argument.actual.enum.singleLine",
"name": "scopes/kotlin/argument/argument.actual.enumConstant.singleLine",
"languageId": "kotlin",
"facet": "argument.actual.enum.singleLine",
"facet": "argument.actual.enumConstant.singleLine",
"code": "enum class Foo {\n bar(aaa, bbb)\n}",
"scopes": [
{
Expand Down Expand Up @@ -1062,9 +1062,9 @@
]
},
{
"name": "scopes/kotlin/argumentList/argumentList.actual.enum.empty",
"name": "scopes/kotlin/argumentList/argumentList.actual.enumConstant.empty",
"languageId": "kotlin",
"facet": "argumentList.actual.enum.empty",
"facet": "argumentList.actual.enumConstant.empty",
"code": "enum class Foo {\n bar()\n}",
"scopes": [
{
Expand All @@ -1079,9 +1079,9 @@
]
},
{
"name": "scopes/kotlin/argumentList/argumentList.actual.enum.multiLine",
"name": "scopes/kotlin/argumentList/argumentList.actual.enumConstant.multiLine",
"languageId": "kotlin",
"facet": "argumentList.actual.enum.multiLine",
"facet": "argumentList.actual.enumConstant.multiLine",
"code": "enum class Foo {\n bar(\n aaa,\n bbb\n )\n}",
"scopes": [
{
Expand All @@ -1096,9 +1096,9 @@
]
},
{
"name": "scopes/kotlin/argumentList/argumentList.actual.enum.singleLine",
"name": "scopes/kotlin/argumentList/argumentList.actual.enumConstant.singleLine",
"languageId": "kotlin",
"facet": "argumentList.actual.enum.singleLine",
"facet": "argumentList.actual.enumConstant.singleLine",
"code": "enum class Foo {\n bar(aaa, bbb)\n}",
"scopes": [
{
Expand Down Expand Up @@ -2095,9 +2095,9 @@
]
},
{
"name": "scopes/kotlin/functionCall/functionCall.enum",
"name": "scopes/kotlin/functionCall/functionCall.enumConstant",
"languageId": "kotlin",
"facet": "functionCall.enum",
"facet": "functionCall.enumConstant",
"code": "enum class Foo {\n bar()\n}",
"scopes": [
{
Expand Down Expand Up @@ -2240,9 +2240,9 @@
]
},
{
"name": "scopes/kotlin/functionCallee/functionCallee.enum",
"name": "scopes/kotlin/functionCallee/functionCallee.enumConstant",
"languageId": "kotlin",
"facet": "functionCallee.enum",
"facet": "functionCallee.enumConstant",
"code": "enum class Foo {\n bar()\n}",
"scopes": [
{
Expand Down
Loading
Loading