Repository navigation
Conversation
Bumped the nitpicker from 0.7.3 to 0.10.1 and turned its breathing rules on across the sources and its design ones on the renderer's components, sparing the ui primitives that wrap react95 chrome. Swept what the new rules flagged: blank lines between a statement and the return that follows it, and JSDoc on the type fields, constructors and inline IPC listeners that carried none. Kept "no-raw-control-element" as a warning with an allow list for the two places a flat button is deliberate, the react95 Button is beveled window chrome and reads wrong as a list row or a theme option.
Added an "Open in Code Editor" entry next to "Open in Terminal". No desktop OS associates a folder with an editor the way it does a file with an app, so the ones we know about are looked for by hand and the first one installed wins. Windows checks absolute install paths with their %VAR% placeholders expanded, a bare name is useless there since spawn does no PATHEXT lookup and the "code" shim on PATH is a .cmd Node refuses to run without a shell. macOS hands the .app bundle to "open" and checks it on disk first, since "open" spawns fine and only then exits non-zero for an application that is not there. Linux is left to PATH. Added a "codeEditorPath" preference for every editor the list does not cover, used exclusively once set so a wrong path errors out rather than silently opening another editor, which would read as the setting being ignored. Kept both failure messages short enough for the offending path to still fit, the error dialog is a fixed-size window and clips anything past about four lines.
Made the update chip clickable the way the auto-lock and C++ database ones already are, so the release notes can be read before committing to the update rather than the download starting on the spot. Stopped the button's click from reaching the chip behind it, so the verb that was pressed is the one that runs.
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.