auto-label UTXOs from transaction notes - #1356
Draft
sneurlax wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1356 +/- ##
===========================================
- Coverage 4.84% 4.83% -0.01%
===========================================
Files 1092 1092
Lines 109141 109159 +18
===========================================
Hits 5283 5283
- Misses 103858 103876 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 19:01
The file predates the current formatter, and CI checks the formatting of every changed file, so it has to be formatted before the next commit can touch it. No behaviour change.
Isar.open only looks for libisar.so on the system loader path and in the working directory, and neither holds it on a fresh checkout or in CI. Resolve the binary shipped with isar_community_flutter_libs instead, so a test can open a real Isar with no manual step and no network download.
Copy a transaction note into the labels of that transaction's outputs at the MainDB boundary, in either arrival order: updateUTXOs picks up a note stored before its outputs, putTransactionNotes labels outputs stored before their note. Only a blank label is ever written, so a label the user set by hand is never overwritten. Batch the six confirm/send screens' per-txid note writes into a single call wrapped by saveTransactionNotesAfterSend, so a note that fails to persist after a successful broadcast is no longer reported to the user as a failed send. Closes #411
sneurlax
force-pushed
the
feat/411-auto-label-utxos
branch
2 times, most recently
from
August 24, 2026 21:31
5f558a4 to
5fc0e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #411