Skip to content

feat: coin control row tap-to-toggle and per-address options menu - #1378

Draft
sneurlax wants to merge 2 commits into
stagingfrom
feat/406-coin-control-improvements
Draft

feat: coin control row tap-to-toggle and per-address options menu#1378
sneurlax wants to merge 2 commits into
stagingfrom
feat/406-coin-control-improvements

Conversation

@sneurlax

Copy link
Copy Markdown
Member

Tapping an address/output row now toggles its selection instead of opening the details view. A vertical ellipsis options button is added to the right of each row to reach the address options. Keeps the filtering, WillPopScope migration, and the UTXOConfirmedStatus deduplication from the prior work.

closes #406

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 400 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.84%. Comparing base (8208fe7) to head (fb00543).
⚠️ Report is 11 commits behind head on staging.

Files with missing lines Patch % Lines
lib/pages/coin_control/coin_control_view.dart 0.00% 217 Missing ⚠️
.../pages_desktop_specific/coin_control/utxo_row.dart 0.00% 78 Missing ⚠️
lib/pages/coin_control/utxo_details_view.dart 0.00% 68 Missing ⚠️
lib/pages/coin_control/utxo_card.dart 0.00% 31 Missing ⚠️
lib/pages/coin_control/utxo_confirmed_status.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1378   +/-   ##
========================================
  Coverage     4.84%    4.84%           
========================================
  Files         1092     1093    +1     
  Lines       109141   109139    -2     
========================================
  Hits          5283     5283           
+ Misses      103858   103856    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sneurlax

Copy link
Copy Markdown
Member Author

Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it

@sneurlax
sneurlax marked this pull request as draft August 20, 2026 18:57
These three files predate the current formatter, so any change to them
fails the repository's CI format gate. Reformat them on their own so the
change that follows reads as a behaviour diff.
Coin control rows behaved like "open details" buttons: tapping anywhere on
a card navigated away, and selection was only reachable through the small
status circle. Tapping a row now toggles its selection on both mobile and
desktop, and a trailing options button takes over navigation to the output
details.

SelectableUtxoSurface is the shared tap target; coin_control_rules.dart
holds the filter and selection predicates the mobile view uses across its
flat, search and grouped-by-address lists. The grouped query now honours
the Available/Frozen filter instead of always querying every output, so a
frozen output selected in grouped mode can be unfrozen from there.
@sneurlax
sneurlax force-pushed the feat/406-coin-control-improvements branch from c21e68e to 56f1a67 Compare August 25, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coin control menu address improvements

1 participant