Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams now decide who can use an app. With no teams, every account uses every app as before.
The check
Team.allows(session, account, app)is the one place that reads a team's app list:A bot account keeps its own rules. A person with no account counts as a member of no team. No key skips the check.
Where it runs
mount(). That covers the app's pages, operations, uploads, and its MCP and chat tools.Workflow.start, for the run's account. A refused start raisesPermissionDeniedand starts nothing. A scheduled run makes the same check for the unattended account.get_gateandanswer_gate. The check comes before any other answer about the run.Each route gate is a dependency in
druks/teams/dependencies.py. A refusal answers 403 with the codeAPP_PERMISSION_DENIEDand names the app.A run that started is never refused later because a team changed. Inside a workflow body the answer is recorded in a step, so a replay reuses it.
Platform
druks.exceptions.PermissionDenied: one error for a thing an account may not do, besideValidationError. The server answers 403 with its message.Software Factory
build.rejected).Not in this change
The reads that span apps (the dashboard, the activity feed, the app roster), Slack buttons and answer links. A member still sees a refused app in the sidebar.