Repository navigation
fix: read wrapped list items and escapes in Sigma YAML - #39
Merged
Merged
Conversation
Running the import over the SigmaHQ rules folder found two reader bugs: plain list items continued on a deeper line failed to parse, and double-quoted \u, \x and \U escapes came out as literal letters. Record the measured conversion coverage in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37:
rules import-sigmawas run over the SigmaHQrulesfolder (3,155 files, commit b7920ed), one file at a time.Coverage
windows/process_creation).not597, null or empty values 92,cidr/base64offset/fieldrefmodifiers 33, more than 16 branches 6, patterns over 32 KiB 2.Fixes
falsepositivesentry).\u,\xand\Uescapes came out as literal letters, so the Cyrillic homoglyph rules searched foru0410. The reader now decodes the full YAML escape set and rejects invalid escapes.Each fix has a regression test with hand-written YAML. The CHANGELOG line now has the measured numbers.