Skip to content

(Claude) Upgrade Playwright to 1.64.1 so Chromium installs on Ubuntu 26.04 - #376

Merged
cboos merged 2 commits into
mainfrom
dev/playwright-ubuntu-26
Nov 5, 2026
Merged

cboos merged 2 commits into
mainfrom
dev/playwright-ubuntu-26

Conversation

@cboos

@cboos cboos commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

ubuntu-latest now resolves to the Ubuntu 26.04 runner image, and CI on main fails before any test runs:

ERROR: Playwright does not support chromium on ubuntu26.04-x64

Playwright 1.56.0 maps any Ubuntu 26 or later host to ubuntu26.04-x64, and it has no browser download for that platform, so playwright install chromium stops there. 1.64.1 ships builds for it. The same failure hits a fresh playwright install on a local Ubuntu 26.04 machine, though browsers installed earlier keep running.

This upgrades Playwright to 1.64.1 in uv.lock only; pytest-playwright stays at 0.7.2. Chromium moves from 141.0.7390.37 to 156.0.8078.4. The browser tests (just test-browser) pass unchanged locally on Ubuntu 26.04: 396 passed, 1 skipped.

Playwright 1.64 bundles its driver, so server/registry/nativeDeps.js is gone. test/test_foldyard_config.py now reads the per-distro package lists from lib/coreBundle.js, where they sit in the same shape. The dev box's [box].packages already covers Chromium 156's Debian 13 dependencies, so foldyard.toml is unchanged. Removing one package from it makes the test fail and name that package.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated dependency-list verification to match the current Playwright package layout.

`ubuntu-latest` now resolves to the Ubuntu 26.04 image. Playwright 1.56.0
maps that host to `ubuntu26.04-x64`, for which it has no browser
download, so `playwright install chromium` failed before any test ran.
1.64.1 ships builds for it. Chromium moves from 141.0.7390.37 to
156.0.8078.4; the browser tests pass unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The test now reads Playwright’s Debian dependency lists from coreBundle.js instead of nativeDeps.js. A comment notes the Playwright 1.64 path change and possible failure if the file moves.

Changes: Playwright dependency-list path

Layer / File(s) Summary
Update dependency-list path
test/test_foldyard_config.py
The test points to coreBundle.js and includes a comment about the Playwright 1.64 path change and possible file access or parsing failures if the path moves.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • daaain/claude-code-log#373: This PR also concerns the Playwright install failure on Ubuntu 26.04. Its pytest-playwright version constraint may need to align with this PR’s lockfile.

Suggested reviewers: daaain

Merge Risk: Minimal · up to a5564

The localized Playwright dependency-path update has no identified merge-blocking issue.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: upgrading Playwright to 1.64.1 to enable Chromium installation on Ubuntu 26.04.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: adb0f4d3-9e08-48f7-a752-14afa20a8add
Commits

Reviewing files that changed from the base of the PR and between 0d5b34f and a55645f.

Files selected for processing: 1

  • test/test_foldyard_config.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Playwright 1.64 bundles its driver, so server/registry/nativeDeps.js is
gone and the per-distro lists the foldyard config test parses now sit in
lib/coreBundle.js, in the same shape. Point the test there. The box's
packages already cover Chromium 156's Debian 13 dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cboos
cboos merged commit c854bd9 into main Nov 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant