Skip to content

(Claude) Read the page filter's toggles and counts from the timeline's map #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboos merged 5 commits into from
Nov 7, 2026
Merged

(Claude) Read the page filter's toggles and counts from the timeline's map #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
743722d
Check that the page filter expands toggles through the timeline's map
cboos Nov 7, 2026
95f39a6
Expand the page filter's toggles through the timeline's map
cboos Nov 7, 2026
a7d7ee7
Check that the toggle counts follow the timeline's map too
cboos Nov 7, 2026
c8cebb0
Count the toggles' cards through the timeline's map
cboos Nov 7, 2026
b4a5622
Check the toggles' visible counts with the moved cards shown
cboos Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions claude_code_log/html/templates/components/timeline.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,11 @@
return { timelineItems, timelineGroups, timelineEnd, timelineStart };
}

// The timeline groups a filter toggle governs. Mirrors the toggle
// expansion in the transcript's applyFilter: the single "Tool" toggle
// stands for both tool groups, and "User" also covers the
// The timeline groups a filter toggle governs: the single "Tool"
// toggle stands for both tool groups, and "User" also covers the
// user-initiated bash lines. Every other toggle governs the group of
// its own name.
// its own name. The transcript's applyFilter expands toggles through
// this same map (exported below as window.timelineToggleGroups).
const TOGGLE_GROUPS = {
'tool': ['tool_use', 'tool_result'],
'user': ['user', 'bash-input', 'bash-output']
Expand Down
115 changes: 22 additions & 93 deletions claude_code_log/html/templates/transcript.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,12 +729,22 @@ <h3>🔍 Search & Filter</h3>
closeToolbarButton.addEventListener('click', toggleFilterToolbar);
}

// The cards a filter toggle covers, through the same toggle map
// as applyFilter: "User" also counts the bash lines, "Tool" both
// tool types.
function toggleCardSelector(type, extra = '') {
const toggleGroups = window.timelineToggleGroups;
return (toggleGroups[type] || [type])
.map(t => `.message.${t}:not(.session-header)${extra}`)
.join(', ');
}

// Count messages by type and update button labels
function updateMessageCounts() {
const messageTypes = ['assistant', 'sidechain', 'memory', 'system', 'thinking', 'image'];
const messageTypes = ['user', 'system', 'assistant', 'thinking', 'tool', 'sidechain', 'memory', 'image'];

messageTypes.forEach(type => {
const messages = document.querySelectorAll(`.message.${type}:not(.session-header)`);
const messages = document.querySelectorAll(toggleCardSelector(type));
const count = messages.length;
const toggle = document.querySelector(`[data-type="${type}"]`);
const countSpan = toggle ? toggle.querySelector('.count') : null;
Expand All @@ -750,36 +760,6 @@ <h3>🔍 Search & Filter</h3>
}
}
});

// Handle combined "user" filter (user + bash-input + bash-output)
const userMessages = document.querySelectorAll(`.message.user:not(.session-header), .message.bash-input:not(.session-header), .message.bash-output:not(.session-header)`);
const userCount = userMessages.length;
const userToggle = document.querySelector(`[data-type="user"]`);
const userCountSpan = userToggle ? userToggle.querySelector('.count') : null;

if (userCountSpan) {
userCountSpan.textContent = `(${userCount})`;
if (userCount === 0) {
userToggle.style.display = 'none';
} else {
userToggle.style.display = 'flex';
}
}

// Handle combined "tool" filter (tool_use + tool_result)
const toolMessages = document.querySelectorAll(`.message.tool_use:not(.session-header), .message.tool_result:not(.session-header)`);
const toolCount = toolMessages.length;
const toolToggle = document.querySelector(`[data-type="tool"]`);
const toolCountSpan = toolToggle ? toolToggle.querySelector('.count') : null;

if (toolCountSpan) {
toolCountSpan.textContent = `(${toolCount})`;
if (toolCount === 0) {
toolToggle.style.display = 'none';
} else {
toolToggle.style.display = 'flex';
}
}
}

// Filter functionality
Expand All @@ -788,18 +768,13 @@ <h3>🔍 Search & Filter</h3>
.filter(toggle => toggle.classList.contains('active'))
.map(toggle => toggle.dataset.type);

// Expand filter types to their corresponding CSS classes
const expandedTypes = [];
activeTypes.forEach(type => {
if (type === 'tool') {
expandedTypes.push('tool_use', 'tool_result');
} else if (type === 'user') {
// User filter includes bash commands (user-initiated)
expandedTypes.push('user', 'bash-input', 'bash-output');
} else {
expandedTypes.push(type);
}
});
// Expand filter types to their corresponding CSS classes,
// through the map the timeline filters its groups by
// (timeline.html), so the two cannot disagree: "Tool" stands
// for both tool types, "User" also covers the user-initiated
// bash lines, and every other toggle its own type.
const toggleGroups = window.timelineToggleGroups;
const expandedTypes = activeTypes.flatMap(type => toggleGroups[type] || [type]);

// Show/hide messages based on active toggle buttons
const allMessages = document.querySelectorAll('.message:not(.session-header)');
Expand Down Expand Up @@ -849,11 +824,11 @@ <h3>🔍 Search & Filter</h3>
}

function updateVisibleCounts() {
const messageTypes = ['assistant', 'sidechain', 'memory', 'system', 'thinking', 'image'];
const messageTypes = ['user', 'system', 'assistant', 'thinking', 'tool', 'sidechain', 'memory', 'image'];

messageTypes.forEach(type => {
const visibleMessages = document.querySelectorAll(`.message.${type}:not(.session-header):not(.filtered-hidden)`);
const totalMessages = document.querySelectorAll(`.message.${type}:not(.session-header)`);
const visibleMessages = document.querySelectorAll(toggleCardSelector(type, ':not(.filtered-hidden)'));
const totalMessages = document.querySelectorAll(toggleCardSelector(type));
const visibleCount = visibleMessages.length;
const totalCount = totalMessages.length;

Expand All @@ -875,52 +850,6 @@ <h3>🔍 Search & Filter</h3>
}
}
});

// Handle combined "user" filter separately (includes bash messages)
const visibleUserMessages = document.querySelectorAll(`.message.user:not(.session-header):not(.filtered-hidden), .message.bash-input:not(.session-header):not(.filtered-hidden), .message.bash-output:not(.session-header):not(.filtered-hidden)`);
const totalUserMessages = document.querySelectorAll(`.message.user:not(.session-header), .message.bash-input:not(.session-header), .message.bash-output:not(.session-header)`);
const visibleUserCount = visibleUserMessages.length;
const totalUserCount = totalUserMessages.length;

const userToggle = document.querySelector(`[data-type="user"]`);
const userCountSpan = userToggle ? userToggle.querySelector('.count') : null;

if (userCountSpan && totalUserCount > 0) {
const activeTypes = Array.from(filterToggles)
.filter(toggle => toggle.classList.contains('active'))
.map(toggle => toggle.dataset.type);

const isFiltering = activeTypes.length < filterToggles.length;

if (isFiltering && visibleUserCount !== totalUserCount) {
userCountSpan.textContent = `(${visibleUserCount}/${totalUserCount})`;
} else {
userCountSpan.textContent = `(${totalUserCount})`;
}
}

// Handle combined "tool" filter separately
const visibleToolMessages = document.querySelectorAll(`.message.tool_use:not(.session-header):not(.filtered-hidden), .message.tool_result:not(.session-header):not(.filtered-hidden)`);
const totalToolMessages = document.querySelectorAll(`.message.tool_use:not(.session-header), .message.tool_result:not(.session-header)`);
const visibleToolCount = visibleToolMessages.length;
const totalToolCount = totalToolMessages.length;

const toolToggle = document.querySelector(`[data-type="tool"]`);
const toolCountSpan = toolToggle ? toolToggle.querySelector('.count') : null;

if (toolCountSpan && totalToolCount > 0) {
const activeTypes = Array.from(filterToggles)
.filter(toggle => toggle.classList.contains('active'))
.map(toggle => toggle.dataset.type);

const isFiltering = activeTypes.length < filterToggles.length;

if (isFiltering && visibleToolCount !== totalToolCount) {
toolCountSpan.textContent = `(${visibleToolCount}/${totalToolCount})`;
} else {
toolCountSpan.textContent = `(${totalToolCount})`;
}
}
}

function toggleFilter(button) {
Expand Down
Loading
Loading