chore: bump pylance to 11.0.0 - #66
Merged
Merged
Conversation
- Raise the pylance floor from 8.0.0 to 11.0.0 and relock (lance-namespace stays at 0.8.6, within pylance 11's <0.9 cap). - ZONEMAP now supports all column types (lance#8017), so the string-column test asserts the index is built instead of expecting a failure. - take_blobs returns Optional[BlobFile] (lance#7903); narrow the type in the write test. Claude-Session: https://claude.ai/code/session_017ZCLiXSVbAbtEV7z8smf8D
FANNG1
force-pushed
the
chore/bump-pylance-11
branch
from
September 11, 2026 02:43
d21129a to
23968ce
Compare
Contributor
Author
|
@universalmind303 @rchowell could you help to review this PR? thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=8.0.0to>=11.0.0and relock to 11.0.0lance-namespaceat 0.8.6: pylance 11 requires>=0.8.5,<0.9daft_lancesource changes are neededLance changes that affect daft-lance
test_build_distributed_index_zonemap_invalid_string_columnexpected ZONEMAP on a string column to fail. It now builds, so the test is renamed to..._zonemap_string_columnand asserts the index is created.LanceDataset.take_blobsreturnsOptional[BlobFile]and keeps results aligned with the requested row ids, sotest_lancedb_write_blobnow narrows theOptional. As a side effect,daft_lance.take_blobsno longer fails on null blobs (on pylance 8 it failed with a length mismatch). A regression test for that will come with the #65 fix.I also checked these breaking changes against daft-lance and they need no changes:
Overwritecommits freshly written fragments without deletion files, andinsert_overwritecommits anUpdate.max_source_rows/max_source_bytescompaction options. These are only additions.Lockfile
The committed
uv.lockuses a compact style that nouv lockversion writes, so relocking would reformat the entire file (about 1.3k lines). I resolved withuv lock --upgrade-package pylance(uv 0.11.2, the version pinned by the pre-commituv-lockhook) and copied only the changedpylanceanddaft-lanceentries into the existing file. The result is semantically identical to uv's output, anduv lock --checkpasses.Validation
DAFT_RUNNER=ray, ray 2.55.1): 368 passed. The 4 failures are alltake_blobstests failing withcannot pickle 'builtins.LanceBlobFile' object. They fail the same way on pylance 8.0.0 and are tracked in take_blobs fails on the Ray runner: LanceBlobFile is not picklable #65.ruff format --checkandruff check: passhttps://claude.ai/code/session_017ZCLiXSVbAbtEV7z8smf8D