Skip to content

Fix | Resolve Helm refs from the repository root - #516

Open
ak-a wants to merge 1 commit into
dag-andersen:mainfrom
ak-a:anking/fix-UPPI-13296-ref-root
Open

ak-a wants to merge 1 commit into
dag-andersen:mainfrom
ak-a:anking/fix-UPPI-13296-ref-root

Conversation

@ak-a

@ak-a ak-a commented Nov 3, 2026

Copy link
Copy Markdown

When a source sets both ref and path, the repo-server API renderer looks for Helm $ref/... files under path. This can cause a remote RPC fallback or select the wrong file. Argo CD resolves these references from the repository root.

Use the repository root for file checks and staging. Keep path for the source's own manifests. Add regression tests for local and remote charts, conflicting files, optional values, file parameters, and dynamic paths.

Validation: make run-unit-tests GO_TEST_FLAGS=-mod=readonly passed, including race and coverage checks. golangci-lint run passed with no issues.

Keep source.path for manifest generation. Resolve referenced values and file parameters from the checkout root, as Argo CD does.

Co-Authored-By: Codex <noreply@openai.com>
@dag-andersen

Copy link
Copy Markdown
Owner

@ak-a Thank you for the PR! Unfortunately, I don't have time to review it before KubeCon next week :) I'll come back to this

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants