Repository navigation
Conversation
Keep source.path for manifest generation. Resolve referenced values and file parameters from the checkout root, as Argo CD does. Co-Authored-By: Codex <noreply@openai.com>
Owner
|
@ak-a Thank you for the PR! Unfortunately, I don't have time to review it before KubeCon next week :) I'll come back to this |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a source sets both
refandpath, the repo-server API renderer looks for Helm$ref/...files underpath. This can cause a remote RPC fallback or select the wrong file. Argo CD resolves these references from the repository root.Use the repository root for file checks and staging. Keep
pathfor the source's own manifests. Add regression tests for local and remote charts, conflicting files, optional values, file parameters, and dynamic paths.Validation:
make run-unit-tests GO_TEST_FLAGS=-mod=readonlypassed, including race and coverage checks.golangci-lint runpassed with no issues.