Skip to content

Fix | Don't set Helm releaseName on chart sources that use a plugin - #520

Merged
dag-andersen merged 1 commit into
dag-andersen:mainfrom
jchanam:fix/skip-release-name-for-plugin-sources
Nov 18, 2026
Merged

dag-andersen merged 1 commit into
dag-andersen:mainfrom
jchanam:fix/skip-release-name-for-plugin-sources

Conversation

@jchanam

@jchanam jchanam commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #519

What

SetHelmReleaseNameIfUnset (#411) adds helm.releaseName to every source with a chart. A source can also pull a chart and render it through a Config Management Plugin (chart + plugin). Argo CD rejects a source with both helm and plugin (multiple application sources defined: Helm,Plugin), so those Applications never render and the run times out.

This skips sources that set plugin, for both source and sources[]. Everything else keeps the behaviour from #411.

Testing

  • Two new cases in TestSetHelmReleaseNameIfUnset: a single chart source with a plugin, and a multi-source Application where only the source without a plugin gets releaseName. Both fail without the change.
  • go test ./cmd/... ./pkg/... and go vet pass. I couldn't run golangci-lint locally (my build is older than Go 1.26), so CI will be its first run.
  • Built the branch and ran it against a kind cluster with Argo CD chart 10.12.1 on 6 changed Applications, including a chart + plugin: {} one. All 12 renders succeed; with v0.2.17 the run times out on that Application.
  • Integration tests not run locally.

🤖 Generated with Claude Code

Since dag-andersen#411, every source with a chart gets helm.releaseName. A source can
also pull a chart and render it with a Config Management Plugin
(chart + plugin). Argo CD rejects a source with both helm and plugin
("multiple application sources defined: Helm,Plugin"), so the
Application never renders and the run times out.

Skip sources that set plugin, single and multi-source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@dag-andersen dag-andersen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the contribution. I don't use plugins, so i don't know much about the edge cases here

@dag-andersen
dag-andersen merged commit 171bfbb into dag-andersen:main Nov 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug | helm.releaseName breaks chart sources that use a plugin (multiple application sources defined: Helm,Plugin)

2 participants