Repository navigation
Fix | Don't set Helm releaseName on chart sources that use a plugin - #520
Merged
dag-andersen merged 1 commit intoNov 18, 2026
Merged
dag-andersen merged 1 commit into
dag-andersen merged 1 commit into
Conversation
Since dag-andersen#411, every source with a chart gets helm.releaseName. A source can also pull a chart and render it with a Config Management Plugin (chart + plugin). Argo CD rejects a source with both helm and plugin ("multiple application sources defined: Helm,Plugin"), so the Application never renders and the run times out. Skip sources that set plugin, single and multi-source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dag-andersen
approved these changes
Nov 18, 2026
dag-andersen
left a comment
Owner
There was a problem hiding this comment.
Thank you so much for the contribution. I don't use plugins, so i don't know much about the edge cases here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519
What
SetHelmReleaseNameIfUnset(#411) addshelm.releaseNameto every source with achart. A source can also pull a chart and render it through a Config Management Plugin (chart+plugin). Argo CD rejects a source with bothhelmandplugin(multiple application sources defined: Helm,Plugin), so those Applications never render and the run times out.This skips sources that set
plugin, for bothsourceandsources[]. Everything else keeps the behaviour from #411.Testing
TestSetHelmReleaseNameIfUnset: a single chart source with a plugin, and a multi-source Application where only the source without a plugin getsreleaseName. Both fail without the change.go test ./cmd/... ./pkg/...andgo vetpass. I couldn't rungolangci-lintlocally (my build is older than Go 1.26), so CI will be its first run.chart+plugin: {}one. All 12 renders succeed; with v0.2.17 the run times out on that Application.🤖 Generated with Claude Code