Skip to content

fix(acp)!: emit native v2 error stop reasons - #44

Merged
danielkov merged 5 commits into
mainfrom
feat/unstable-subagents
Oct 30, 2026
Merged

danielkov merged 5 commits into
mainfrom
feat/unstable-subagents

Conversation

@danielkov

@danielkov danielkov commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Emit ACP v2’s native error stop reason when accepted prompt work fails. Release agentkit-acp 0.12.0 and agentkit 0.13.0 against published agentkit-acp-sdk 3.6.0, replacing the temporary Git dependency.

Impact

ACP v2 idle-state failures use the standard error stop reason instead of the private _error extension. The prerequisite schema represents v2 stop reasons as tagged objects; v1 behavior is unchanged.

Technical details

Pin SDK 3.6.0 directly so external consumers receive the required protocol types without workspace overrides. Forward the ACP stdio feature to the SDK and adapt the v2 resource-not-found constructor to the released API. The lockfile uses registry SDK, derive, and schema releases rather than Git or local-path sources.

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required SDK revision is selected only inside this workspace; external protocol-v2 consumers still resolve the registry SDK and cannot compile the newly referenced native error types.

Took 15 min

Comment thread Cargo.toml Resolved

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

Took 10 min

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

Took 27 min

@danielkov
danielkov merged commit 940e328 into main Oct 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant