Repository navigation
Isolate provider fixtures and serialize Docker companion preparation - #875
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent runtime fixtures reused a mutable Docker image tag, and OpenCode fixture discovery could reach shared
/tmp/node_modulesoutside the selected test workspace. Give each fixture an owned, labeled image tag with ownership-checked cleanup, and keep both provider fixtures' synthetic projects within their own temporary homes with explicit input selections.Preserve a bounded, redacted backend cause in supervisor activation-failure logs so a refused launch identifies its underlying error.
Run the Docker-heavy local companion with one worker. The default parallel run intermittently exhausted its unchanged preparation timeout; all 21 provider companion tests across four files pass with one worker, retaining the same timeout and assertions. Cloud shard scheduling stays unchanged.
Validation: all 21 provider companion tests pass (779s), the actual supervisor failure-handler regression passes, overlapping-image lifetime tests pass, and 29 orchestration tests plus the full TypeScript checks pass. Normal pre-push checks passed, including the affected Rust tests.