DAOS-19345 build: propagate no_proxy/NO_PROXY through SCons MINIMAL_ENV#18696
Open
knard38 wants to merge 1 commit into
Open
DAOS-19345 build: propagate no_proxy/NO_PROXY through SCons MINIMAL_ENV#18696knard38 wants to merge 1 commit into
knard38 wants to merge 1 commit into
Conversation
|
Ticket title is 'SConstruct: |
MINIMAL_ENV defines the whitelist of env vars forwarded into SCons's ENV
dict, used as the subprocess environment for all build commands (see
site_scons/prereq_tools/base.py):
rc = subprocess.call(cmd, ..., env=passed_env['ENV'])
It already included 'http_proxy'/'https_proxy' so the corporate proxy
reaches build subprocesses, but 'no_proxy'/'NO_PROXY' were absent,
meaning any bypass rules set by the caller were silently stripped
before build subprocesses saw the environment, while the proxy URL
itself was preserved.
On hosts where the proxy cannot reach internal package mirrors (e.g.
an on-premises Artifactory instance), the missing no_proxy causes
pip/uv subprocesses invoked during dependency builds (e.g. rebuilding
the spdk prereq's Python bindings) to route requests for the mirror
through the proxy, which then times out.
The existing _copy_env() guard ('if value:') prevents empty strings
from being forwarded when the variables are unset in the caller's
environment, so this change is a no-op for builds that do not
configure a proxy.
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
knard38
force-pushed
the
ckochhof/fix/master/daos-19345/patch-001
branch
from
July 22, 2026 08:30
b35b9eb to
3d3b384
Compare
knard38
changed the title
phender
approved these changes
Jul 22, 2026
daltonbohning
approved these changes
Jul 22, 2026
Contributor
Author
|
@daos-stack/daos-gatekeeper could you lend this PR with the following message:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a build host has an HTTP proxy configured (
http_proxy/https_proxy) together with ano_proxy/NO_PROXYbypass list for hosts that should be reached directly,scons --build-deps=yescan fail to reach those bypassed hosts.SConstruct'sMINIMAL_ENVallow-list — used by_copy_env()to build theENVdict passed to build subprocesses (seesite_scons/prereq_tools/base.py) — forwardshttp_proxy/https_proxybut notno_proxy/NO_PROXY. Subprocesses such aspip/uvtherefore inherit the proxy with no bypass exemption at all, and route requests for hosts that should be reached directly through a proxy that may not be able to reach them.Add
no_proxyandNO_PROXYtoMINIMAL_ENVtoSConstruct, mirroring the existinghttp_proxy/https_proxyentries:_copy_env()'s existingif value:guard (unchanged) already skips variables that aren't set in the caller's environment, so this is a no-op for any build that doesn't configure a proxy.Steps for the author:
After all prior steps are complete: