Decouple request context and trace header from package:appengine - #9617
Merged
Merged
Conversation
…ntext-and-logging
sigurdm
added this pull request to stack #9640
October 1, 2026 09:58
isoos
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouples request handling and trace propagation from
package:appengine'sClientContext:X-Cloud-Trace-Contextpropagation (app/lib/shared/utils.dart,app/lib/shared/handler_helpers.dart):X-Cloud-Trace-Contextat the start of_logRequestWrapperand bind it to the request zone viawithTraceId.currentTraceIdincloudTraceHeaders()and_logRequestWrappererror responses instead ofpackage:appengine'scontext.traceId.FakeClientContext(app/lib/shared/handler_helpers.dart,app/lib/service/services.dart):!envConfig.isRunningLocallyinstead ofcontext.isProductionEnvironmentin_httpsWrapperand removeFakeClientContext.