Repository navigation
Mirror ReservedPackage entities into SQL. - #9638
Merged
Merged
Conversation
jonasfj
reviewed
Oct 1, 2026
| Future<void> mirrorReservedPackageToSql(ReservedPackage rp) async { | ||
| await primaryDatabase.withRetry( | ||
| (db) => db.reservedPackages | ||
| .upsertValue( |
Member
There was a problem hiding this comment.
should we only insert if it's not already there?
Collaborator
Author
There was a problem hiding this comment.
The admin operation may create or update the email list of the entity, we should just use upsert here.
backfillReservedPackagesSqlFromDatastore could use an existence check though, I'll add it.
sigurdm
approved these changes
Oct 1, 2026
isoos
force-pushed
the
reserved-package
branch
from
October 1, 2026 08:41
61080e1 to
1742ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: a single-shot migration seems to risk the ability to rollback the release, so opting for the multi-step migration.