feat(qt): DashPay usernames, contacts and contact payments - #7627
Closed
PastaPastaPasta wants to merge 8 commits into
Closed
feat(qt): DashPay usernames, contacts and contact payments#7627PastaPastaPasta wants to merge 8 commits into
PastaPastaPasta wants to merge 8 commits into
Conversation
native_rust installs the pinned prebuilt Rust toolchain as a native package and rust_stdlib provides the precompiled standard library for every supported cross target; contrib/devtools/update-rust-hashes.py maintains both pins together. funcs.mk gains a cargo environment wired to the depends cross toolchain and a per-package crate-vendoring template: any package that declares a vendored archive name and a cargo manifest gets a vendor-<package>-crates target and extracts the archive before building, so cargo builds run locked and fully offline.
…I knob
PLATFORM_GUI=1 adds mbedtls, native_protobuf, tenderdash_sources and platform_cxx to the package set. platform_cxx builds libdash_platform_cxx.a and its installed headers from a pinned dashpay/platform commit (packages/rs-platform-cxx), offline via the per-package vendored crates. config.site.in exports enable_platform_gui and PLATFORM_CXX_{CFLAGS,LIBS} discovery for the configure flag that arrives with the first C++ consumer.
…lane The new lane builds depends with PLATFORM_GUI=1 (producing and hash-verifying the Platform CXX archive offline from vendored crates), then builds dash-qt against that prefix and runs the unit tests. The cache-sources producer generates and caches the platform-cxx vendored-crates archive, handing it to same-run consumers as an artifact on cache miss. The --enable-platform-gui configure flag is added to this lane's BITCOIN_CONFIG by the Platform client library PR; until then the lane proves the depends knob and prefix link-compatibility. build.yml runs PR validation from the base branch (pull_request_target), so the lane first runs on push CI for this branch and takes effect for PRs after merge.
libdash_platform.a is a DAPI client for the Dash Platform GUI: a gRPC-Web-over-TLS transport on mbedtls with per-query endpoint pinning and scoped freshness, GroveDB drive queries whose proofs verify through the Platform-owned CXX bridge bound to the quorum-signed root, DPP identity/document decoding and state-transition construction where the signable bytes are the broadcast bytes, and versioned serialization for DashPay's per-wallet records. The new --enable-platform-gui configure flag requires the GUI and wallet, autodetects mbedtls and link-tests the Platform CXX archive from depends. Nothing outside the flag changes: dashd and default builds do not compile or link any of this.
Unit suites for the transport (dechunking, retry, freshness), DPP and drive layers run against Rust-generated fixed vectors: GroveDB proofs (keys, ranges, subqueries, absence, references, sum trees), DPP identities and state transitions, drive queries and quorum signatures. platformkeys_tests gains Platform record round-trip and payment-cursor coverage, and a fuzz target exercises the bridge's decode and verify entry points.
…lane The lane introduced with the depends knob now passes --enable-platform-gui to configure, so the platform unit suites run in CI.
createAssetLockTransaction builds and funds an asset lock paying credits to a Platform funding key, at the payload version consensus accepts: version 2 is invalid until the v24 hard fork applies to the next block, and version 1 stays valid after activation, so a transaction built at the boundary is safe either way. CommitTransaction gains an optional broadcast_error out-parameter and a matching interfaces::Wallet::commitTransaction overload: a mempool rejection is reported to the caller instead of only the log, while the transaction stays committed to the wallet so the caller may abandon it. Both seams are wallet-type-agnostic and compiled unconditionally.
Adds the DashPay tab behind --enable-platform-gui: username registration (asset lock, identity registration and DPNS preorder/domain as a crash-recoverable state machine), a profile dialog, contacts with encrypted DIP-15 xpub exchange and private receiving-chain import, send-to-username contact payments with per-contact payment cursors, and seed-only recovery that rediscovers identities, contacts and payment cursors from Platform and wallet history. The tab requires a descriptor wallet: legacy wallets get a migrate prompt and cannot reach any Platform flow or spend. The Send dialog's temporarily-unavailable distinction is guarded under ENABLE_PLATFORM_GUI so default builds keep their exact error behavior.
This was referenced Aug 20, 2026
|
This pull request has conflicts, please rebase. |
This was referenced Sep 8, 2026
Member
Author
|
Disposition (not closing yet): superseded by #7671, which is this PR's two commits with a 7-line seam change (client construction takes the Platform LLMQ type, the five builder call sites pass the SDK handle, mbedtls leaves the Qt link lines). Map in #7512. 🤖 Posted autonomously by Claude on behalf of pasta. |
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 8, 2026
The DashPay GUI: username registration (identity + DPNS), a dashboard with profile, contacts over encrypted DIP-15 xpubs, seed-only recovery and send-to-username contact payments, all inside --enable-platform-gui (default off). Carried over from dashpay#7627 unchanged apart from the seam to the client library: the service constructs the SDK-backed client with the network's Platform LLMQ type, and the state-transition builders take the client's SDK handle so transitions are built under the protocol version the SDK has seen the network run. The Qt link lines lose mbedtls, which left depends with the C++ transport. Validated on aarch64-apple-darwin: dash-qt builds and links the SDK archive (Security + CoreFoundation frameworks only), the DashPay tab, wizard and flows compile against the unchanged PlatformClient interface.
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 9, 2026
The DashPay GUI: username registration (identity + DPNS), a dashboard with profile, contacts over encrypted DIP-15 xpubs, seed-only recovery and send-to-username contact payments, all inside --enable-platform-gui (default off). Carried over from dashpay#7627 unchanged apart from the seam to the client library: the service constructs the SDK-backed client with the network's Platform LLMQ type, and the state-transition builders take the client's SDK handle so transitions are built under the protocol version the SDK has seen the network run. The Qt link lines lose mbedtls, which left depends with the C++ transport. Validated on aarch64-apple-darwin: dash-qt builds and links the SDK archive (Security + CoreFoundation frameworks only), the DashPay tab, wizard and flows compile against the unchanged PlatformClient interface.
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 9, 2026
The DashPay GUI: username registration (identity + DPNS), a dashboard with profile, contacts over encrypted DIP-15 xpubs, seed-only recovery and send-to-username contact payments, all inside --enable-platform-gui (default off). Carried over from dashpay#7627 unchanged apart from the seam to the client library: the service constructs the SDK-backed client with the network's Platform LLMQ type, and the state-transition builders take the client's SDK handle so transitions are built under the protocol version the SDK has seen the network run. The Qt link lines lose mbedtls, which left depends with the C++ transport. Validated on aarch64-apple-darwin: dash-qt builds and links the SDK archive (Security + CoreFoundation frameworks only), the DashPay tab, wizard and flows compile against the unchanged PlatformClient interface.
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 9, 2026
The DashPay GUI: username registration (identity + DPNS), a dashboard with profile, contacts over encrypted DIP-15 xpubs, seed-only recovery and send-to-username contact payments, all inside --enable-platform-gui (default off). Carried over from dashpay#7627 unchanged apart from the seam to the client library: the service constructs the SDK-backed client with the network's Platform LLMQ type, and the state-transition builders take the client's SDK handle so transitions are built under the protocol version the SDK has seen the network run. The Qt link lines lose mbedtls, which left depends with the C++ transport. Validated on aarch64-apple-darwin: dash-qt builds and links the SDK archive (Security + CoreFoundation frameworks only), the DashPay tab, wizard and flows compile against the unchanged PlatformClient interface.
Member
Author
|
Closing as superseded by #7671. Comparing the branches confirms that the DashPay GUI workflows and wallet interfaces were carried forward with the SDK client integration; the replacement also contains further persistence, recovery and payment fixes. Continue review and descriptor-wallet end-to-end validation on #7671, with series tracking in #7512. 🤖 Posted autonomously by Codex on behalf of pasta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Third PR of the DashPay series (stacked on #7623 → #7626; tracking: #7512). This adds the DashPay GUI itself: username registration (identity + DPNS), a DashPay dashboard with profile, contacts (contact requests over encrypted DIP-15 xpubs) and send-to-username contact payments — all inside
--enable-platform-gui, default off.What was done?
Commits up to and including the
linux64_platform_guiCI commit are #7623 + #7626 — review the commits after those.feat(wallet)commit):createAssetLockTransaction(builds and funds an asset-lock at the version consensus accepts — v1 until the v24 fork applies to the next block, v2 after; covered inevo_assetlocks_tests) and acommitTransactionoverload surfacing the mempool/broadcast error to the caller instead of logging it. Both are wallet-type-agnostic and flag-independent.src/qt/platform/:PlatformService(per-wallet lifecycle, DAPI client ownership, record storage via the 7581 seams),IdentityFlow(asset lock → identity register → DPNS preorder/domain state machine, crash-recoverable),CreateUsernameWizard(QDialog + QStackedWidget — depends Qt is built-no-feature-wizard), contacts (model/page/picker, encrypted-xpub contact requests, DIP-15 receiving-chain import viaensureFriendshipReceivingKeychain),PlatformRecovery(seed-only restore: identity probe by key hash, contact re-import, payment-cursor rebuild from wallet history), profile dialog.ENABLE_PLATFORM_GUI(it previously changed Send-error behavior for all builds — review finding).How Has This Been Tested?
isComplete()gating, stack-localUnlockContextrelock — fixed on the branch), and a live-testnet E2E: identity registration, DPNS username claim, contact request/accept round-trip and a contact payment against real evonodes, driven through the actual dash-qt UI.--enable-platform-guibuild (dash-qt links the platform stack), platform + wallet unit suites, qt tests.Breaking Changes
None. Default builds are unaffected; the feature is behind
--enable-platform-gui.Checklist: