Conversation
Based on audit findings
… and DashPay shielded address Add contract groups to the data contract explanation and proofs page, and describe how non-master authentication keys can be bound to a contract, document type, or contract group and carry a credit budget and expiry. Note that identity creation from the shielded pool rejects such keys. Add the shieldedAddress profile property to the embedded DashPay contract and describe its privacy and validation behavior. Include epoch schedules in the token claim description.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…drawal fee rules Add a contract groups section to the data contract reference covering registration, group ID derivation, admins, membership kinds, and the validation rules. Add the contractGroup and contractGroupMemberships fields to the Data Contract Create transition and note that it now supports format versions 0 and 1. Document the public key contractBounds variants and their protocol 14 authentication semantics, and add the totalBudget and expiresAt key limit fields along with the remaining budget behavior. Note the protocol 14 requirement on the supported protocol versions for the identity transitions that can carry such keys. Describe the protocol 14 Core fee rules for withdrawals across the identity, address, and shielded pool references: the 6,765 duffs/byte cap, the fee taken from the withdrawn amount, and the resulting fee-inclusive minimums. Split the protocol constants withdrawal rows accordingly and add a maximum Core fee per byte row. Correct the two- and six-key identity creation examples, which omitted the asset lock cost. State the protocol 14 minimum of one epoch for epoch based token distribution intervals. Document the document create id collision rules including the contested tree check. Add the 22 new consensus error codes, extend the state range to 41099, and add a contract group state section. Rename max_contract_group_size to max_group_member_count and distinguish it from contract groups. Refresh the embedded meta-schema comment and update source line anchors that had shifted.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview build: https://dash-docs-platform--163.org.readthedocs.build/en/163/