-
Notifications
You must be signed in to change notification settings - Fork 7
fix: unpin the platform protocol version so clients auto-detect #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
26a90c2
fix: unpin the platform protocol version so clients auto-detect
thepastaclaw cd7fcc8
test: catch a stale platform version pin in the read-only suite
thepastaclaw 01efd80
test(example-apps): give the SDK stubs a version() method
thepastaclaw 953a77b
fix(example-apps): align lite SDK versions
thepastaclaw 254c74d
test: split platform-version and lite-SDK checks into their own files
thephez 45d513d
test: guard the unpinned SDK version offline and across networks
thephez c78b5cb
docs: update readme and claude
thephez b3d195e
docs: scope the .env prerequisite to the tutorial suites
thephez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { readFileSync } from 'node:fs'; | ||
| import { describe, it } from 'node:test'; | ||
|
|
||
| const litePages = [ | ||
| ['dashmint-lab', 'dashmint-lite.html'], | ||
| ['dashnote', 'dashnote-lite.html'], | ||
| ['dashrate', 'dashrate-lite.html'], | ||
| ['dashproof-lab', 'dashproof-lite.html'], | ||
| ]; | ||
|
|
||
| describe('Standalone lite SDK versions', () => { | ||
| for (const [appName, pageName] of litePages) { | ||
| it(`${appName} matches its companion app`, () => { | ||
| const appDirectory = new URL( | ||
| `../example-apps/${appName}/`, | ||
| import.meta.url, | ||
| ); | ||
| const packageJson = JSON.parse( | ||
| readFileSync(new URL('package.json', appDirectory), 'utf8'), | ||
| ); | ||
| const page = readFileSync( | ||
| new URL(`public/${pageName}`, appDirectory), | ||
| 'utf8', | ||
| ); | ||
| const expectedImport = | ||
| `https://esm.sh/@dashevo/evo-sdk@` + | ||
| packageJson.dependencies['@dashevo/evo-sdk']; | ||
| const sdkImports = [ | ||
| ...page.matchAll( | ||
| /from\s+['"](https:\/\/esm\.sh\/@dashevo\/evo-sdk@[^'"]+)['"]/g, | ||
| ), | ||
| ].map((match) => match[1]); | ||
|
|
||
| assert.deepEqual( | ||
| sdkImports, | ||
| [expectedImport], | ||
| `${pageName} must import exactly the SDK version from ${appName}/package.json`, | ||
| ); | ||
| }); | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { describe, it } from 'node:test'; | ||
| import { EvoSDK } from '@dashevo/evo-sdk'; | ||
| import { createClient } from '../setupDashClient-core.mjs'; | ||
|
|
||
| const trustedFactories = [ | ||
| ['testnet', 'testnetTrusted'], | ||
| ['mainnet', 'mainnetTrusted'], | ||
| ['local', 'localTrusted'], | ||
| ]; | ||
|
|
||
| describe('Platform protocol version configuration', () => { | ||
| for (const [network, factoryName] of trustedFactories) { | ||
| it(`${network} leaves the SDK version unpinned`, async (t) => { | ||
| const sdk = { connect: t.mock.fn(async () => {}) }; | ||
| const factory = t.mock.method(EvoSDK, factoryName, () => sdk); | ||
|
|
||
| assert.equal(await createClient(network), sdk); | ||
| assert.equal(factory.mock.callCount(), 1); | ||
| assert.deepEqual(factory.mock.calls[0].arguments, []); | ||
| assert.equal(sdk.connect.mock.callCount(), 1); | ||
| }); | ||
| } | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.