chore: fix rustfmt drift on v4.2-dev - #4278
Conversation
cargo fmt --check fails on the current branch head in rs-platform-wallet-ffi/src/dashpay.rs and rs-sdk-ffi/src/signer.rs, so every open PR's Tests (macOS) formatting step fails regardless of its own changes. Output of cargo fmt, nothing else. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 43 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
ℹ️ Review skipped (commit 0a57fc1) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.2-dev #4278 +/- ##
============================================
- Coverage 87.53% 87.52% -0.01%
============================================
Files 2678 2678
Lines 343721 341047 -2674
============================================
- Hits 300888 298518 -2370
+ Misses 42833 42529 -304
🚀 New features to boost your workflow:
|
Issue being fixed or feature implemented
cargo fmt --check --allfails on the currentv4.2-devhead (verified on a clean checkout of7afc8a8ff3) with three diffs inpackages/rs-platform-wallet-ffi/src/dashpay.rsandpackages/rs-sdk-ffi/src/signer.rs, introduced by recently merged kotlin-sdk FFI PRs. Since CI builds each PR's merge ref against the branch head, theRust workspace tests / Tests (macOS)formatting step currently fails for every open PR targetingv4.2-dev(e.g. it just failed on #4276, which touches neither file).What was done?
cargo fmt -p rs-sdk-ffi -p platform-wallet-ffi— the tool's own output, nothing else.cargo fmt --all --checkis clean afterwards.How Has This Been Tested?
Formatting-only change;
cargo fmt --all --checkpasses on the branch.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code