Skip to content

chore: fix rustfmt drift on v4.2-dev - #4278

Merged
QuantumExplorer merged 1 commit into
v4.2-devfrom
chore/fmt-drift-ffi
Aug 4, 2026
Merged

chore: fix rustfmt drift on v4.2-dev#4278
QuantumExplorer merged 1 commit into
v4.2-devfrom
chore/fmt-drift-ffi

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

cargo fmt --check --all fails on the current v4.2-dev head (verified on a clean checkout of 7afc8a8ff3) with three diffs in packages/rs-platform-wallet-ffi/src/dashpay.rs and packages/rs-sdk-ffi/src/signer.rs, introduced by recently merged kotlin-sdk FFI PRs. Since CI builds each PR's merge ref against the branch head, the Rust workspace tests / Tests (macOS) formatting step currently fails for every open PR targeting v4.2-dev (e.g. it just failed on #4276, which touches neither file).

What was done?

cargo fmt -p rs-sdk-ffi -p platform-wallet-ffi — the tool's own output, nothing else. cargo fmt --all --check is clean afterwards.

How Has This Been Tested?

Formatting-only change; cargo fmt --all --check passes on the branch.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

cargo fmt --check fails on the current branch head in
rs-platform-wallet-ffi/src/dashpay.rs and rs-sdk-ffi/src/signer.rs,
so every open PR's Tests (macOS) formatting step fails regardless of
its own changes. Output of cargo fmt, nothing else.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QuantumExplorer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 56021ea2-fba8-4dd2-8389-ea8309d085dd

📥 Commits

Reviewing files that changed from the base of the PR and between 7afc8a8 and 0a57fc1.

📒 Files selected for processing (2)
  • packages/rs-platform-wallet-ffi/src/dashpay.rs
  • packages/rs-sdk-ffi/src/signer.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

ℹ️ Review skipped (commit 0a57fc1)
Last checked: 2026-08-04 06:01 UTC

@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 4, 2026
@QuantumExplorer
QuantumExplorer merged commit f53e5ee into v4.2-dev Aug 4, 2026
18 of 19 checks passed
@QuantumExplorer
QuantumExplorer deleted the chore/fmt-drift-ffi branch August 4, 2026 05:58
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.52%. Comparing base (189a3ab) to head (0a57fc1).
⚠️ Report is 3 commits behind head on v4.2-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           v4.2-dev    #4278      +/-   ##
============================================
- Coverage     87.53%   87.52%   -0.01%     
============================================
  Files          2678     2678              
  Lines        343721   341047    -2674     
============================================
- Hits         300888   298518    -2370     
+ Misses        42833    42529     -304     
Components Coverage Δ
dpp 88.49% <ø> (-0.08%) ⬇️
drive 86.26% <ø> (+0.08%) ⬆️
drive-abci 89.57% <ø> (-0.10%) ⬇️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.88% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 49.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants