fix(sdk): point parity manifest at the renamed identity-resume test - #4304
Conversation
#4015 renamed testInvitationVouchersAreExcludedFromResumableList to testFundingTypeGateAcceptsOnlyGenericIdentityResumeTypes in CreateIdentityResumableTests.swift but left the manifest entry behind, so check_sdk_parity_manifest.py fails on every PR against v4.2-dev. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 56 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit b06a94b) |
There was a problem hiding this comment.
Final validation — Codex + Sonnet
The PR correctly updates the Swift verification identifier in the SDK parity manifest to match the renamed test in CreateIdentityResumableTests.swift. The referenced test exists, the obsolete identifier has no remaining references, the manifest validator passes, and all 11 parity-manifest unit tests pass. No in-scope defects were found.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed) - Verifier:
gpt-5.6-sol— final-verifier (Sonnet verifier fallback) - Sonnet reviewers:
claude-sonnet-5— general (completed)
Issue being fixed or feature implemented
#4015 renamed
testInvitationVouchersAreExcludedFromResumableListtotestFundingTypeGateAcceptsOnlyGenericIdentityResumeTypesinCreateIdentityResumableTests.swiftbut left the old id indocs/sdk/sdk-parity-manifest.json, socheck_sdk_parity_manifest.pyfails the "Kotlin SDK build + tests" job on every PR targeting v4.2-dev (first seen on #4300's run).What was done?
Updated the
identity.asset_lock_resumecapability's Swift unit verification id to the renamed test.How Has This Been Tested?
python3 scripts/check_sdk_parity_manifest.py(now reports "SDK parity manifest OK: 22 capabilities; summary current") andpython3 -m unittest discover -s scripts/tests -p 'test_*.py'(11 tests OK).Breaking Changes
None.
Checklist:
🤖 Generated with Claude Code