Skip to content

fix(sdk): point parity manifest at the renamed identity-resume test - #4304

Merged
QuantumExplorer merged 1 commit into
v4.2-devfrom
fix/sdk-parity-manifest-resume-test-rename
Aug 6, 2026
Merged

fix(sdk): point parity manifest at the renamed identity-resume test#4304
QuantumExplorer merged 1 commit into
v4.2-devfrom
fix/sdk-parity-manifest-resume-test-rename

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

#4015 renamed testInvitationVouchersAreExcludedFromResumableList to testFundingTypeGateAcceptsOnlyGenericIdentityResumeTypes in CreateIdentityResumableTests.swift but left the old id in docs/sdk/sdk-parity-manifest.json, so check_sdk_parity_manifest.py fails the "Kotlin SDK build + tests" job on every PR targeting v4.2-dev (first seen on #4300's run).

What was done?

Updated the identity.asset_lock_resume capability's Swift unit verification id to the renamed test.

How Has This Been Tested?

python3 scripts/check_sdk_parity_manifest.py (now reports "SDK parity manifest OK: 22 capabilities; summary current") and python3 -m unittest discover -s scripts/tests -p 'test_*.py' (11 tests OK).

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

🤖 Generated with Claude Code

#4015 renamed testInvitationVouchersAreExcludedFromResumableList to
testFundingTypeGateAcceptsOnlyGenericIdentityResumeTypes in
CreateIdentityResumableTests.swift but left the manifest entry behind,
so check_sdk_parity_manifest.py fails on every PR against v4.2-dev.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QuantumExplorer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fb261c74-f297-4314-9593-a23a1610dc60

📥 Commits

Reviewing files that changed from the base of the PR and between 1de13e9 and b06a94b.

📒 Files selected for processing (1)
  • docs/sdk/sdk-parity-manifest.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 5, 2026
@QuantumExplorer QuantumExplorer changed the title fix(docs): point parity manifest at the renamed identity-resume test fix(sdk): point parity manifest at the renamed identity-resume test Aug 5, 2026
@thepastaclaw

thepastaclaw commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit b06a94b)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Codex + Sonnet

The PR correctly updates the Swift verification identifier in the SDK parity manifest to match the renamed test in CreateIdentityResumableTests.swift. The referenced test exists, the obsolete identifier has no remaining references, the manifest validator passes, and all 11 parity-manifest unit tests pass. No in-scope defects were found.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed)
  • Verifier: gpt-5.6-sol — final-verifier (Sonnet verifier fallback)
  • Sonnet reviewers: claude-sonnet-5 — general (completed)

@QuantumExplorer
QuantumExplorer merged commit ec0beb9 into v4.2-dev Aug 6, 2026
18 of 19 checks passed
@QuantumExplorer
QuantumExplorer deleted the fix/sdk-parity-manifest-resume-test-rename branch August 6, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants