test: withdraw above the protocol 14 minimum in the JS withdrawal tests - #4781
Conversation
Since eaf5d4c the Core fee of the asset unlock transaction is carved out of the withdrawn amount, so identity credit withdrawal structure v2 requires at least min_withdrawal_amount plus that fee (1190000 credits at 1 duff per byte). The wasm-sdk functional test and the platform-test-suite e2e test still withdrew exactly the old minimum of 1000000 credits and failed on every pull request against v4.2-dev with "Credit withdrawal amount 1000000 must be greater or equal to 1190000". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 15th in line, estimated start in ~3 h (commit f9ad556)
|
Issue being fixed or feature implemented
Since eaf5d4c (withdrawal transaction accounting) the Core fee of the asset unlock transaction is carved out of the withdrawn amount, so identity credit withdrawal structure v2 requires at least
min_withdrawal_amountplus that fee: 1,190,000 credits at 1 duff per byte. The wasm-sdk functional test and the platform-test-suite e2e withdrawal test still withdrew exactly the old minimum of 1,000,000 credits, so the "Packages functional tests" and "Test Suite" jobs fail on every pull request against v4.2-dev (for example on #4613 and #4780) with:What was done?
Both tests withdraw 2,000,000 credits, leaving headroom above the new minimum, with the comments updated to explain where the minimum comes from. No production code changes.
How Has This Been Tested?
Amounts checked against
min_withdrawal_amount_with_core_fee(SystemLimits::min_withdrawal_amount1,000,000 plusASSET_UNLOCK_TX_SIZEtimes the fee rate timesCREDITS_PER_DUFF). The identities in both tests are funded with far more than the new amounts. CI on this PR runs the affected suites.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code