acc: run ssh/connect-serverless-gpu locally#5878
Draft
radakam wants to merge 2 commits into
Draft
Conversation
Flip acceptance/ssh/connect-serverless-gpu to Local = true so it runs against the in-process testserver (it was disabled on both cloud and local in #4838). A full SSH handshake can't complete locally (no real compute/sshd + a wss driver-proxy), so the local run drives the connect flow up to the connection attempt and asserts the serverless GPU bootstrap job the CLI submits (accelerator, environment, secret scope). Teach libs/testserver enough of the SSH tunnel backend for the flow to get there deterministically and fast: - secrets/list (ListSecretsByScope), returning RESOURCE_DOES_NOT_EXIST for a missing scope so CreateKeysSecretScope creates it - synthesize metadata.json on the ssh-server-bootstrap run submit, as a real tunnel server would publish it, so getServerMetadata succeeds - driver-proxy metadata/logs endpoints - workspace/export now 404s a missing object instead of returning a nil body (which the response normalizer rejects) The connect attempt itself is expected to fail locally; its noisy output goes to LOG.stderr (excluded from the golden files).
Collaborator
Integration test reportCommit: 5097357
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 10 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs
acceptance/ssh/connect-serverless-gpulocally against the in-process testserver (it was disabled on cloud and local in #4838).A full SSH handshake can't complete locally (no real compute/
sshd, plus awss://driver-proxy websocket and a realsshspawn), so the local run drives the connect flow up to the connection attempt and asserts what the CLI actually controls: the serverless-GPU bootstrap job it submits (GPU_1xA10, serverless env, secret scope, notebook task).To reach that point fast and deterministically,
libs/testservergains:secrets/list→RESOURCE_DOES_NOT_EXISTfor a missing scope, soCreateKeysSecretScopecreates itmetadata.jsononssh-server-bootstrap-*submit (as the real tunnel server would publish)metadata/logsendpointsworkspace/exportreturns404for a missing object instead of a nil bodyThe connect attempt's noisy failure output goes to
LOG.stderr(excluded from goldens); the cloud path (Connection successful) is preserved for when cloud is re-enabled.