Skip to content

Winston's filing works: tool accepts both shapes, fills ids; deploy checks what Hermes loads - #305

Merged
plur9 merged 2 commits into
mainfrom
fix/plugin-deploy-verify
Nov 7, 2026
Merged

plur9 merged 2 commits into
mainfrom
fix/plugin-deploy-verify

Conversation

@plur9

@plur9 plur9 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

On 2026-11-07, a backup folder inside ~/.hermes/plugins/ had the same plugin name, and Hermes loaded it instead of the deployed copy. As a result, Winston ran without the routing frame and the stall guard all evening, even though both were reported live.

This PR:

  • adds verify_loaded.py, which runs under the Hermes interpreter and fails if it finds a second copy of the plugin, a wrong load path or a missing hook;
  • makes deploy.sh copy that script and run it after deploying;
  • updates plugin.yaml to declare pre_llm_call and all five tools.

Verification:

  • Tests written first: 2 failed before the fix, and 107 passed after.
  • The check passes in Winston's live pod.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MrfsFu7NLgapPn6yUcNxE5

plur9 and others added 2 commits November 7, 2026 22:37
…hook and tool

On 2026-11-07 a backup folder in ~/.hermes/plugins/ carried the same plugin name and Hermes loaded it instead of the deployed copy, so the routing frame and stall guard were absent while reported live. verify_loaded.py runs under the Hermes interpreter and fails on a second copy, a wrong load path or a missing hook; deploy.sh runs it after copying.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MrfsFu7NLgapPn6yUcNxE5
…g item id

Dry runs of Winston on a real request (2026-11-07): the model gave fields at the top level or nested type/space inside payload, was refused, and gave up; filings without id would be skipped by the fold. Five dry runs after this change: 5/5 filed, within two calls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MrfsFu7NLgapPn6yUcNxE5
@plur9 plur9 changed the title hermes plugin: deploy checks what Hermes loads; manifest lists every hook and tool Winston's filing works: tool accepts both shapes, fills ids; deploy checks what Hermes loads Nov 7, 2026
@plur9

plur9 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Added: the filing tool now accepts fields at the top level or nested inside payload, and generates an id when it's missing. Without an id, the ledger skips the item when building its view, so nobody would see it. Evidence: 5 dry runs of Winston in his pod on the owner's real request, with only the final ledger write swapped out. Before this change, 2 of 3 runs never filed. After it, 5 of 5 filed within two calls. Tests: 112 passed.

@plur9
plur9 merged commit d08b251 into main Nov 7, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant