Restore truthful Web answer streaming on v1.11.4 - #1000
Draft
Y1fe1Zh0u wants to merge 2 commits into
Draft
Conversation
Connect existing provider streaming callbacks to tenant-scoped, coalesced Runtime observations and the existing Web Chat chunk consumer. Attempt identity, ordered replay, protocol filtering, canonical terminal replacement, and a default-off rollout gate keep provisional output separate from execution and delivery truth. Constraint: LangGraph checkpoint and delivered ChatMessage remain the only lifecycle and final-result authorities Constraint: No new dependencies or database migration Rejected: Write every token into checkpoint state | violates Runtime ownership and amplifies persistence cost Rejected: Push provider callbacks directly to WebSocket | couples Worker progress to one process and client Rejected: Retry or fail over after visible output | can splice incompatible provider attempts Confidence: high Scope-risk: moderate Directive: Keep AGENT_RUNTIME_WEB_STREAMING_ENABLED disabled for fleet rollout until real-provider concurrency and database load are measured Tested: Backend 2557 passed; focused 245 passed; frontend 122 passed; production build; scoped Ruff; Architecture Guard P0; git diff --check Not-tested: Real provider TTFT, multi-worker crash canary, enabled-path load, 3010 deployment
Enable the reviewed Runtime streaming path by default while preserving AGENT_RUNTIME_WEB_STREAMING_ENABLED=false as an operational rollback. Constraint: User explicitly selected default-on behavior and approved backporting the validated change to v1.11.4 Confidence: high Scope-risk: moderate Directive: Keep the false override available until broader real-provider concurrency and database load are validated Tested: Backend 2557 passed; frontend 122 passed; production build; scoped Ruff; Architecture Guard P0; git diff --check Not-tested: Additional v1.11.4 deployment beyond the existing 3010 canary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_RUNTIME_WEB_STREAMING_ENABLED=falseretained as rollbackScope
Web Direct Chat only. This PR does not add Clawith native-group, Feishu CardKit, or WeCom streaming. No migration or new dependency.
Validation
git diff --checkpassedassistant_deltaevents verified; two physical attempts reset correctly without concatenation; no browser console errorsRemaining live boundary
The canary Agent produced complete visible output but remained in verification/repair and its cancel command did not settle immediately. That is recorded as a separate Runtime terminal/cancellation issue, not counted as streaming completion proof.
Rollout risk
Enabled-path concurrency, database write load, and broader real-provider TTFT remain to be measured before broad production rollout.