Repository navigation
UK/Fix dspace-customers 1083 finding 29: create the Shibboleth SP key when the container starts - #1702
Open
milanmajchrak wants to merge 2 commits into
Open
UK/Fix dspace-customers 1083 finding 29: create the Shibboleth SP key when the container starts#1702milanmajchrak wants to merge 2 commits into
milanmajchrak wants to merge 2 commits into
Conversation
The test image ran shib-keygen at build time, so every container shared one key pair stored in an image layer. The startup script now creates it on the first start and keeps an existing or mounted pair. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit d34a597)
The startup script now also runs make-ssl-cert, so the image contains no private key file. Existing files are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 4c07eb6)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
dspace-customers issue 1083, finding 29. Same change as #1693 (commits d34a597 and 4c07eb6) on dtq-dev.
Description
The
dspace-shibbolethtest image now creates the Shibboleth SP key pair and Apache's self-signed certificate when a container starts for the first time, not duringdocker build. The image itself contains no private key file.Instructions for Reviewers
List of changes in this PR:
Dockerfile: theshib-keygenstep is removed. Thessl-cert-snakeoilfiles that thessl-certpackage creates are deleted in the same step that installs it.httpd-shibd-foreground.sh: same file as on dtq-dev. It runsshib-keygen -b -o /etc/shibbolethandmake-ssl-cert generate-default-snakeoilbeforeshibdand Apache start, keeps files that already exist, and stops with a clear message if only one ofsp-key.pemandsp-cert.pemexists.README.md: a short note on where the keys come from and how to keep a fixed SP key.The test commands from the dtq-dev PR pass on #1694, whose
dspace-shibbolethfolder is the same as on this branch: the image has no private key file, two containers get different keys, a mounted pair is kept, a restart keeps the key, andshibdand Apache run.Codex review (gpt-6.2-sol, high) of the first commit: it raised package-generated keys (the image has none). Checked and left as is. The second commit is the same diff as on dtq-dev, where Codex reviewed it.
AI Disclosure (REQUIRED)
Were AI tools used in the creation of this PR?
Claude Code applied the dtq-dev change to this branch and ran the same Docker test on #1694, which has the same files.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.🤖 Generated with Claude Code