Repository navigation
ZCU-PUB/fix(item-page): drop embargo badge onto its own line under the filename - #1652
Merged
milanmajchrak merged 5 commits intoNov 5, 2026
Merged
Conversation
…e filename (#1088) The per-bitstream access-status badge ("Embargo until <date>") is rendered by ds-file-download-link right after the download link. The item Files list separates entries with a projected <br/> (FileSectionComponent.separator) that lands inside the link, so the badge wrapped onto the next visual line and ran straight into the following file's lock icon. Scope the custom theme's item-page file section so each file is block-level and the badge drops onto its own line directly under the filename: <lock> filename (size) Embargo until <date> Done via SCSS only (no template duplication); submission and process-detail, which reuse ds-file-download-link, keep their inline layout. Fixes dataquest-dev/dspace-customers#1088 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Drop the `display: block` on the access-status badge so it flows inline after the filename and only wraps onto its own line when it does not fit. Each file stays block-level, so a wrapped badge still cannot collide with the next file's lock icon. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…name (#1088) - add a 0.5rem gap between the filename and the inline access-status badge - word-break: break-all so the filename wraps beside the lock icon instead of jumping to the next line and leaving the lock orphaned on its own line Verified across widths (140-240px): the lock always stays with the start of the filename, and the badge stays inline when it fits, wrapping underneath otherwise. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the embargo-badge position in the ZCU-PUB item view
(dataquest-dev/dspace-customers#1088).
Each file in the Files section is a
ds-file-download-linkthat renders thelock icon + filename, followed by the per-bitstream access-status badge
(
ds-access-status-badge→ "Embargo until<date>"). The Files list separatesentries with a projected
<br/>(FileSectionComponent.separator) that landsinside the link — so the badge wrapped onto the next visual line and ran
straight into the following file's lock icon.
Behaviour
wraps across lines next to the lock instead of jumping to the next line
and leaving the lock alone;
small gap), and drops onto its own line under the filename only when there
isn't room;
How
SCSS only, scoped to the custom theme's item-page file section — no template
duplication, so the base
file-sectiontemplate keeps propagating:ds-file-download-linkis made block-level (one file per line);<br/>separator is neutralised (block layout alreadybreaks between files, so it would otherwise force the badge onto its own line);
word-break: break-allon the link so a long filename wraps beside the lockicon rather than orphaning it on its own line;
0.5remright margin on the link for a gap before the inline badge.The badge keeps its default inline flow, so it stays next to the filename when
there's space and wraps underneath otherwise. Because each file is its own
block, a wrapped badge can't run into the next file.
Submission (
section-upload-file) andprocess-detail, which also reuseds-file-download-link, are not affected (the rule is scoped to:host ::ng-deep .file-section).Verification (local)
accessStatus/embargo REST endpoint), running in Docker.orphaned, long filenames wrap beside the lock, short filenames keep the badge
inline (with a gap), long ones wrap the badge onto the next line, and the open
file shows no badge.
Fixes dataquest-dev/dspace-customers#1088
🤖 Generated with Claude Code