Repository navigation
[Port to dtq-dev] Give required inputs of an optional complex field a required message - #1667
Merged
Merged
Conversation
… required message Port of dtq-dev-9-base PR 1582. An optional complex field such as Funding or Size has no mandatory message, but its inner inputs can be required. They got an undefined required message. Use error.validation.required, the key the server sends for these fields. Only the import lines differ from the source commit, to match the dtq-dev import style. (cherry picked from commit 80f4b5a) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Required inputs of an optional complex field (Funding, Size) get
error.validation.requiredas their required message instead ofundefined.Instructions for Reviewers
List of changes in this PR:
ComplexFieldParser: same change as the source commit. Only the import lines differ, to match the dtq-dev style.complex-field-parser.spec.ts.How to test:
ng test --include=src/app/shared/form/builder/parsers/complex-field-parser.spec.ts. Locally 5/5 specs and eslint pass.AI Disclosure
Claude Code made the cherry-pick and wrote this description. A second agent compared the diff with the source PR line by line.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.🤖 Generated with Claude Code