Skip to content

[Port to dtq-dev] Give required inputs of an optional complex field a required message - #1667

Merged
milanmajchrak merged 1 commit into
dtq-devfrom
ufal/fe-complex-field-required-message
Oct 27, 2026
Merged

milanmajchrak merged 1 commit into
dtq-devfrom
ufal/fe-complex-field-required-message

Conversation

@milanmajchrak

Copy link
Copy Markdown
Collaborator

References

  • Port of dataquest-dev/dspace-angular PR 1582 from dtq-dev-9-base (commit 80f4b5a)

Description

Required inputs of an optional complex field (Funding, Size) get error.validation.required as their required message instead of undefined.

Instructions for Reviewers

List of changes in this PR:

  • ComplexFieldParser: same change as the source commit. Only the import lines differ, to match the dtq-dev style.
  • Three new specs from the source PR in complex-field-parser.spec.ts.

How to test: ng test --include=src/app/shared/form/builder/parsers/complex-field-parser.spec.ts. Locally 5/5 specs and eslint pass.

AI Disclosure

  • No
  • Yes

Claude Code made the cherry-pick and wrote this description. A second agent compared the diff with the source PR line by line.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

… required message

Port of dtq-dev-9-base PR 1582.

An optional complex field such as Funding or Size has no mandatory
message, but its inner inputs can be required. They got an undefined
required message. Use error.validation.required, the key the server
sends for these fields.

Only the import lines differ from the source commit, to match the
dtq-dev import style.

(cherry picked from commit 80f4b5a)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak merged commit 718f726 into dtq-dev Oct 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant