Repository navigation
LINDAT: Run the UI on Node 22 instead of end-of-life Node 18 - #1671
Merged
Merged
Conversation
Node 18 is end of life since April 2025 and gets no security fixes, including CVE-2026-111497 in the Brotli decoder bundled with Node. DSpace 7.6.7 also ships on Node 22. CI now tests on Node 20 and 22. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 35d18f3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Node 18 is end of life and gets no security fixes, including CVE-2026-111497. This moves the Docker images and CI to Node 22.
Instructions for Reviewers
List of changes in this PR:
DockerfileandDockerfile.distusenode:22-alpineinstead ofnode:18-alpine.No application code changes.
How to test:
docker.yml) and runs the tests on Node 20 and 22 (build.yml).docker exec <ui container> node -vprintsv22.23.4or newer and the home page renders. The container has to be recreated (docker compose pull+up -d). A restart keeps the old image.Built
Dockerfile.distof this branch (as committed) locally on Node 22.23.4.yarn lintpasses. Against the dev-5 backend the image renders/homevia SSR with status 200.Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.🤖 Generated with Claude Code