Skip to content

LINDAT: Run the UI on Node 22 instead of end-of-life Node 18 - #1671

Merged
milanmajchrak merged 1 commit into
customer/lindatfrom
lindat/fe-node-22
Oct 28, 2026
Merged

milanmajchrak merged 1 commit into
customer/lindatfrom
lindat/fe-node-22

Conversation

@milanmajchrak

Copy link
Copy Markdown
Collaborator

References

Description

Node 18 is end of life and gets no security fixes, including CVE-2026-111497. This moves the Docker images and CI to Node 22.

Instructions for Reviewers

List of changes in this PR:

  • Dockerfile and Dockerfile.dist use node:22-alpine instead of node:18-alpine.
  • CI tests on Node 20 and 22 instead of 18 and 20. Coverage is uploaded from the 22 job.

No application code changes.

How to test:

  • CI builds both UI images on Node 22 (docker.yml) and runs the tests on Node 20 and 22 (build.yml).
  • After deploy, docker exec <ui container> node -v prints v22.23.4 or newer and the home page renders. The container has to be recreated (docker compose pull + up -d). A restart keeps the old image.

Built Dockerfile.dist of this branch (as committed) locally on Node 22.23.4. yarn lint passes. Against the dev-5 backend the image renders /home via SSR with status 200.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

Node 18 is end of life since April 2025 and gets no security fixes,
including CVE-2026-111497 in the Brotli decoder bundled with Node.
DSpace 7.6.7 also ships on Node 22.

CI now tests on Node 20 and 22.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 35d18f3)
@milanmajchrak
milanmajchrak merged commit 13c08b7 into customer/lindat Oct 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant