Repository navigation
LINDAT/Backport ufal: send only the fields the licence asks for on download - #1682
Merged
milanmajchrak merged 2 commits intoNov 2, 2026
Merged
Conversation
… (ufal/dspace-angular PR 163) * fix(license): ensure IP address is included in anonymous user payload * test(license): add missing template dependencies to spec (cherry picked from commit e183ad8)
…equired metadata keys (ufal/dspace-angular PR 164) * issue 162: filter clarinusermetadata/manage payload to contain only fields required by the license * test(license): cover required-info payload filter and optional ORGANIZATION Spec cases for ufal/dspace-angular PR 164 on top of the ufal/dspace-angular PR 163 spec setup: - only metadata keys required by the license (plus the current IP) are sent - an empty ORGANIZATION does not block "I agree"; an empty REQUIRED_ORGANIZATION still does Both cases fail without ufal/dspace-angular PR 164's component change. --------- Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz> (cherry picked from commit a026caf)
milanmajchrak
added a commit
that referenced
this pull request
Nov 10, 2026
…wnload (#1682) (#1696) * fix(license): ensure IP address is included in anonymous user payload (ufal/dspace-angular PR 163) * fix(license): ensure IP address is included in anonymous user payload * test(license): add missing template dependencies to spec (cherry picked from commit e183ad8) * issue 162: filter clarinusermetadata/manage payload to contain only required metadata keys (ufal/dspace-angular PR 164) * issue 162: filter clarinusermetadata/manage payload to contain only fields required by the license * test(license): cover required-info payload filter and optional ORGANIZATION Spec cases for ufal/dspace-angular PR 164 on top of the ufal/dspace-angular PR 163 spec setup: - only metadata keys required by the license (plus the current IP) are sent - an empty ORGANIZATION does not block "I agree"; an empty REQUIRED_ORGANIZATION still does Both cases fail without ufal/dspace-angular PR 164's component change. --------- (cherry picked from commit a026caf) --------- (cherry picked from commit 33013a0) Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com> Co-authored-by: Amad Ul Hassan <hassan@ufal.mff.cuni.cz> Co-authored-by: Milan Kuchtiak <kuchtiak@ufal.mff.cuni.cz> Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
The licence agreement page sends only the fields the licence asks for, plus the IP. An empty ORGANIZATION no longer blocks "I agree".
Instructions for Reviewers
List of changes in this PR:
-x, no conflicts. ÚFAL stays the author.clarin-license-agreement-page.component.tsdrops user metadata whose key is not in the licence's required info, and always adds the IP, also for anonymous users.clarin-v7.How to test: open a file whose licence requires e.g. NAME. Fill in more fields than it asks for and click "I agree". The POST to
clarinusermetadata/managecarries only NAME and IP.AI Disclosure
Claude Code made the cherry-picks and wrote this description. The touched files were diffed against ufal
clarin-v7.Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.🤖 Generated with Claude Code