Skip to content

LINDAT/SSR static pages no longer trust the Host header; SSR cache keyed by origin and language - #1687

Merged
milanmajchrak merged 1 commit into
customer/lindatfrom
lindat/fe-ssr-host-header-cache-key
Nov 2, 2026
Merged

milanmajchrak merged 1 commit into
customer/lindatfrom
lindat/fe-ssr-host-header-cache-key

Conversation

@milanmajchrak

Copy link
Copy Markdown
Collaborator

References

  • dtq-dev PR 1669, squash commit 60f6ccb
  • dspace-customers issue 1083, finding R22

Description

SSR loads static pages from the origin of ui.baseUrl, not from the Host header. The SSR caches are keyed by origin and language too, so a forged Host can no longer poison them.

Instructions for Reviewers

List of changes in this PR:

  • Clean cherry-pick of 60f6ccb1d430 with -x, no changes. The original author stays.
  • Deploy note: the Node server must reach its own ui.baseUrl with a valid certificate. Otherwise SSR shows the licence and ToS static pages as not found.
  • Only the commit message differs from the source: LINDAT/ title and GitHub refs written as plain text.

How to test: ssr-cache-key.util.spec.ts and html-content.service.spec.ts. By hand: request a static page with a forged Host header. The content still comes from ui.baseUrl.

AI Disclosure

  • No
  • Yes

Claude Code made the cherry-pick and wrote this description.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

…yed by origin and language

* Load SSR static content from the configured UI origin, not the Host header

During SSR, HtmlContentService built the static-file URL from the request
protocol and Host header. A request with a spoofed Host made the server fetch
/static-files/*.html from an attacker origin and render it unsanitized
(dsSafeHtml); the SSR page caches, keyed by path only, could then serve that
render to other visitors.

Use the origin of the configured ui.baseUrl (the address the Node server
listens on) instead and drop the now unused REQUEST injection.

dspace-customers issue 1083, finding R22.

* Key SSR page caches by origin and language, not only by path

getCacheKey returned req.url, but an anonymous SSR render also depends on the
request origin (protocol and Host header, e.g. citation_pdf_url via
getCurrentOrigin) and on the dsLanguage cookie. A request with a forged Host or
another language filled the bot and anonymous caches for everyone requesting
that path.

Move the key to getSsrCacheKey so it can be unit tested and include protocol,
Host and the language cookie. The /reload check now reads req.url, because the
key no longer starts with the path.

dspace-customers issue 1083, finding R22.

* Skip the SSR bot cache for authenticated requests

cacheCheck read the bot cache for any bot user agent before checking for an
authentication cookie, so an authenticated request with a bot user agent got
the anonymous cached page instead of its own render. Read either cache only
for anonymous requests; saveToCache already stores anonymous renders only.

dspace-customers issue 1083, finding R22.

* Do not load static page names that leave static-files once decoded

The static page file name comes from the URL. Express decodes the path before
serving files, so /static/..%2Findex loaded the app's own index.html into the
page. Return no content for a name that contains a path separator after
decoding (the query part is ignored), which renders the existing 404.

dspace-customers issue 1083, finding R22.

---------

Co-authored-by: jm <jm@maz>
(cherry picked from commit 60f6ccb)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak merged commit 0c5bc42 into customer/lindat Nov 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants