Skip to content

LINDAT/fix(security): harden dsAuthInfo auth cookie with Secure and SameSite - #1688

Merged
milanmajchrak merged 1 commit into
customer/lindatfrom
lindat/fe-auth-cookie-secure-samesite
Nov 2, 2026
Merged

milanmajchrak merged 1 commit into
customer/lindatfrom
lindat/fe-auth-cookie-secure-samesite

Conversation

@milanmajchrak

Copy link
Copy Markdown
Collaborator

References

  • dtq-dev PR 1663, squash commit 9bcd483
  • dspace-customers issue 1083, finding R69

Description

The dsAuthInfo auth cookie gets Secure on https pages and SameSite=Lax.

Instructions for Reviewers

List of changes in this PR:

  • Clean cherry-pick of 9bcd48382674 with -x, no changes. The original author stays.
  • Only the commit message differs from the source: LINDAT/ title and GitHub refs written as plain text.

How to test: auth.service.spec.ts. By hand: log in over https and check the cookie flags in the browser dev tools.

AI Disclosure

  • No
  • Yes

Claude Code made the cherry-pick and wrote this description.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

…ameSite

* Harden dsAuthInfo auth cookie with Secure and SameSite attributes

Set secure and sameSite='lax' on the auth JWT cookie written in storeToken(),
as defense-in-depth. The Secure flag is derived from the actual page protocol
(location.protocol === 'https:') so it is applied on any https page, including
behind a TLS-terminating reverse proxy, while local http dev still works.
'lax' is used rather than 'strict' so the cookie is still sent on the top-level
navigation that returns from external authentication.

* docs: shorten auth cookie security comment

---------

Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
(cherry picked from commit 9bcd483)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak merged commit 05966d3 into customer/lindat Nov 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants