Repository navigation
VSB-TUO/Fix dspace-customers 1083 R68: sanitize RefBox citation HTML - #1706
Merged
milanmajchrak merged 1 commit intoNov 3, 2026
Merged
Conversation
Port of dtq-dev PR 1662 (commit a5298dd). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Port of dtq-dev PR 1662 (commit a5298dd). dspace-customers issue 1083, finding R68. BE part: VŠB DSpace PR 1633 (port of DSpace PR 1534).
Description
The RefBox citation is no longer rendered with
bypassSecurityTrustHtml, so Angular's sanitizer strips scripts and event handlers and makesjavascript:links inert. The<i>and<a>formatting stays.Instructions for Reviewers
clarin-ref-citation.component.tspasses the server text to[innerHTML]as a plain string.DomSanitizeris no longer injected.clarin-ref-citation.component.spec.ts: no<script>, noonerror, and thejavascript:link is inert. The italic title and the handle link still render.clarin-ref-citation.component.spec.ts.Checklist
🤖 Generated with Claude Code