Skip to content

VSB-TUO/fix(security): harden dsAuthInfo auth cookie with Secure and SameSite - #1707

Merged
milanmajchrak merged 1 commit into
customer/vsb-tuofrom
vsb-tuo/fe-auth-cookie-secure-samesite
Nov 3, 2026
Merged

milanmajchrak merged 1 commit into
customer/vsb-tuofrom
vsb-tuo/fe-auth-cookie-secure-samesite

Conversation

@milanmajchrak

Copy link
Copy Markdown
Collaborator

References

Port of dtq-dev PR 1663 (commit 9bcd483). dspace-customers issue 1104 (R35).

Description

The dsAuthInfo cookie that holds the auth token was written with only expires. It now also gets SameSite=Lax, and Secure when the page is served over HTTPS.

Instructions for Reviewers

  • AuthService.storeToken() sets secure from location.protocol === 'https:' (through NativeWindowService), so it works behind a TLS proxy and stays off for local HTTP.
  • SameSite=Lax, because Strict would break the external login redirects. vsb-tuo uses password and LDAP login, so this changes nothing in its login flow.
  • The diff is the same as dtq-dev PR 1663. The cherry-pick had no conflicts.
  • Tests: auth.service.spec.ts.

Checklist

  • My PR is created against the branch it ports to
  • My PR is small in size
  • My PR follows the code conventions and passes ESLint
  • My PR passes all specs and includes new or updated specs
  • My PR includes details on how to test it
  • No new dependencies, no new configuration

🤖 Generated with Claude Code

…SameSite

Port of dtq-dev PR 1663 (commit 9bcd483).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak merged commit 50932e0 into customer/vsb-tuo Nov 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant