Repository navigation
VSB-TUO/fix(security): harden dsAuthInfo auth cookie with Secure and SameSite - #1707
Merged
milanmajchrak merged 1 commit intoNov 3, 2026
Merged
Conversation
…SameSite Port of dtq-dev PR 1663 (commit 9bcd483). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Port of dtq-dev PR 1663 (commit 9bcd483). dspace-customers issue 1104 (R35).
Description
The
dsAuthInfocookie that holds the auth token was written with onlyexpires. It now also getsSameSite=Lax, andSecurewhen the page is served over HTTPS.Instructions for Reviewers
AuthService.storeToken()setssecurefromlocation.protocol === 'https:'(throughNativeWindowService), so it works behind a TLS proxy and stays off for local HTTP.SameSite=Lax, becauseStrictwould break the external login redirects. vsb-tuo uses password and LDAP login, so this changes nothing in its login flow.auth.service.spec.ts.Checklist
🤖 Generated with Claude Code