Repository navigation
VSB-TUO/Fix dspace-customers 1083 R22: SSR cache keyed by origin and language, no static file outside static-files - #1708
Merged
milanmajchrak merged 1 commit intoNov 3, 2026
Conversation
…language, no static file outside static-files Port of dtq-dev PR 1669 (commit 60f6ccb). html-content.service on vsb-tuo builds a relative URL and never read the Host header, so only the isPlainFileName guard is taken from that file. The new spec holds only the source test for that guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Port of dtq-dev PR 1669 (commit 60f6ccb). dspace-customers issue 1083, finding R22.
Description
The SSR page caches were keyed by
req.urlonly, and the bot cache was read before the login check. Now the key holds origin, path and language, the bot cache serves only anonymous requests, and a static page name like..%2Findexis refused.Instructions for Reviewers
server.tsand newssr-cache-key.util.ts: the same as the source.html-content.service.ts: only theisPlainFileNameguard is taken. Not applicable: the Host header part. On vsb-tuo this service builds a relative URL and never readsreq.protocolor theHostheader, so there is nothing to replace.html-content.service.spec.tsdoes not exist on vsb-tuo. The new file holds only the source test for the guard (..%2Findexmakes no request). The source tests for the Host header and the namespace do not apply here.ssr-cache-key.util.spec.tsandhtml-content.service.spec.ts.Checklist
🤖 Generated with Claude Code