Repository navigation
VSB-TUO/filter config.json before exposing it - #1711
Merged
Merged
Conversation
Port of dtq-dev PR 1059 (commit 1fa478b). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Port of dtq-dev PR 1069 (commit 8de5005). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
customer/vsb-tuo turns Matomo on in main.browser.ts by reading matomo.enabled from assets/config.json. Without the key the browser never loads the tracker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Port of dtq-dev PR 1059 (commit 1fa478b) and dtq-dev PR 1069 (commit 8de5005). No issue.
Description
config.server.tswrote the whole runtime config, server-only settings included, to the publicconfig.json. Now it writes only the keys the browser needs.Instructions for Reviewers
buildAppConfigwrites apublicConfigwith an allowlist of keys.rest.ssrBaseUrlandcache.msToLive/cache.control, which the browser needs, and comments out thehomepage-statisticse2e test that used the full config.config.server.tsequals dtq-dev after 1069 plus one line.matomoblock also keepsenabled. Only vsb-tuo hasmatomo.enabled, and itsmain.browser.tsreads it fromconfig.jsonto load the tracker. Without it Matomo would stop.matomo.enabled.curl https://<host>/assets/config.jsonshows noui.ssl,ui.host,rest.host,cache.serverSideand noactuators, but stillmatomo.enabled.config.server.ts. The production build runs it.Checklist
🤖 Generated with Claude Code