Skip to content

VSB-TUO/filter config.json before exposing it - #1711

Merged
milanmajchrak merged 3 commits into
customer/vsb-tuofrom
vsb-tuo/fe-filter-public-config
Nov 3, 2026
Merged

milanmajchrak merged 3 commits into
customer/vsb-tuofrom
vsb-tuo/fe-filter-public-config

Conversation

@milanmajchrak

@milanmajchrak milanmajchrak commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

References

Port of dtq-dev PR 1059 (commit 1fa478b) and dtq-dev PR 1069 (commit 8de5005). No issue.

Description

config.server.ts wrote the whole runtime config, server-only settings included, to the public config.json. Now it writes only the keys the browser needs.

Instructions for Reviewers

  • First commit, dtq-dev PR 1059: buildAppConfig writes a publicConfig with an allowlist of keys.
  • Second commit, dtq-dev PR 1069: adds rest.ssrBaseUrl and cache.msToLive/cache.control, which the browser needs, and comments out the homepage-statistics e2e test that used the full config.
  • Both cherry-picks had no conflicts. config.server.ts equals dtq-dev after 1069 plus one line.
  • Adaptation, third commit: the matomo block also keeps enabled. Only vsb-tuo has matomo.enabled, and its main.browser.ts reads it from config.json to load the tracker. Without it Matomo would stop.
  • vsb-tuo has the same top-level config keys as dtq-dev. The nested keys the browser reads are the same too, except matomo.enabled.
  • After deploy: curl https://<host>/assets/config.json shows no ui.ssl, ui.host, rest.host, cache.serverSide and no actuators, but still matomo.enabled.
  • Tests: no spec covers config.server.ts. The production build runs it.

Checklist

  • My PR is created against the branch it ports to
  • My PR is small in size
  • My PR follows the code conventions and passes ESLint
  • My PR passes all specs and includes new or updated specs
  • My PR includes details on how to test it
  • No new dependencies, no new configuration

🤖 Generated with Claude Code

milanmajchrak and others added 3 commits November 3, 2026 10:41
Port of dtq-dev PR 1059 (commit 1fa478b).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Port of dtq-dev PR 1069 (commit 8de5005).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
customer/vsb-tuo turns Matomo on in main.browser.ts by reading
matomo.enabled from assets/config.json. Without the key the browser
never loads the tracker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak merged commit 4d261f1 into customer/vsb-tuo Nov 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant