Repository navigation
Conversation
…DSpace#2315) (cherry picked from commit 951c5f6)
Use the exact createSsrRefreshContext signature and function body from DSpace#6353 at a3f28a8. Keep the existing LRU integration and local lifetime documentation. This is a partial port, not a cherry-pick of the Redis feature. Co-authored-by: qubiack <krzysztof.kubiak@pcgacademia.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs dataquest-dev/dspace-customers#1131.
Change set
Test evidence
DSpace 7.6.5 / Angular 15; Node 20.17.0, Yarn 1.22.22, unchanged yarn.lock.
Original lifecycle tests: 5 failed /3 passed; corrected 9/9. The callback error-diagnostic regression was separately red before its correction. Tests execute actual functions/classes on Express with a stand-in render engine; they do not claim a full Angular server bootstrap. Full build and headless suite exited 0.
Notes
Fresh branch from dtq-dev; no customer history or Angular 19-only APIs imported. Optional Link metadata is best-effort: if late, it is omitted without delaying redirect. Background request metadata is read-only; its socket/body remain owned by the visitor request.
This integration PR does not deploy or backport the change to a customer branch. The tracking issue remains open for that work.
Focused command (Node 20.17 selected):
Circular check used the installed madge 8.0.0 CLI. Portable equivalent (rather than the machine-specific cache path actually executed):
npx --yes --package=madge@8.0.0 madge --exclude '(bitstream|bundle|collection|config-submission-form|eperson|item|version)\.model\.ts$' --circular --extensions ts ./Circular result includes 109 resolver warnings. Local test environment set
NODE_OPTIONS=--max-old-space-size=8192andCHROME_BINto installed Chrome.Upstream overlap checked
Upstream reuse follow-up
128e2c291cdf90afe6658b0743bcba2b330ac777from upstream951c5f69d46db57efb5423c4581b4c895793c6dd(merged PR SSR: avoid sending new response when headers were already sent DSpace/dspace-angular#4733), with original author andcherry picked fromtrailer. Guard comment/block match upstream apart indentation. Conflict resolution retains the Angular 15 callback renderer; the guard therefore precedes both success and error handling. The existing constant diagnostic remains immediately before it.b76be165034b8b9d5bb0fadcf6b505a574ad086duses the exactcreateSsrRefreshContextsignature and full function body from open upstream feat(ssr-cache): add Redis-based server-side rendering cache with tests and configurations DSpace/dspace-angular#6353 ata3f28a8501eed9eddfe9f57a8deb5a10698f0d84. It replaces the prior equivalent helper and is called directly. Original author credited; no duplicate helper, Redis feature or dependency added. Type-only imports, lifetime documentation and legacy LRU call site remain local.Revalidated on
b76be16503: Node lifecycle 9/9, full Jasmine 5549 passed / 4 skipped, full lint pass, production browser+SSR build pass (exit 0). Helper equality verified mechanically with line endings normalized. Claude Opus CLI read-only follow-up found no blocker and confirmed the text matches and renderer-scope difference. Fresh CI is running for this head; previous head's checks were green.