Skip to content

CLARIN-DSpace v9/SSR static pages use the configured UI origin; SSR cache keyed by origin and language - #1718

Open
milanmajchrak wants to merge 2 commits into
dtq-dev-93from
9-base/fe-ssr-static-pages-origin
Open

milanmajchrak wants to merge 2 commits into
dtq-dev-93from
9-base/fe-ssr-static-pages-origin

Conversation

@milanmajchrak

@milanmajchrak milanmajchrak commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

References

Description

During SSR, static HTML pages are loaded from the origin of ui.baseUrl, not from the request Host. The SSR page caches are keyed by protocol, Host, language cookie and path.

Instructions for Reviewers

List of changes in this PR:

  • HtmlContentService: on the server the URL starts with the ui.baseUrl origin. The REQUEST injection is gone.
  • HtmlContentService: a file name that contains / or \ after decoding loads nothing, so the existing 404 is shown.
  • New getSsrCacheKey in ssr-cache-key.util.ts, used by both caches in server.ts.
  • server.ts: the bot cache is read only for anonymous requests, like the anonymous cache. The /reload check uses req.url.

How to test: the specs for html-content.service, ssr-cache-key.util, the static page and the license agreement page pass locally (43). The three new html-content.service specs fail on the old code. ESLint is clean on the changed files. Not tested on a running SSR server.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

milanmajchrak and others added 2 commits November 9, 2026 15:48
…ache keyed by origin and language

During SSR, HtmlContentService built the static-file URL from the request
protocol and Host header. It now uses the origin of the configured
ui.baseUrl, and the unused REQUEST injection is gone.

The SSR page caches were keyed by path only, but an anonymous render also
depends on the request origin and the dsLanguage cookie. The key moves to
getSsrCacheKey (protocol, Host, language cookie, path) so it can be unit
tested. The bot cache is read only for anonymous requests, like the
anonymous cache.

A static page name that contains a path separator once decoded loads
nothing and renders the existing 404.

Source: 60f6ccb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak changed the base branch from dtq-dev-9-base to dtq-dev-93 November 17, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant