Repository navigation
[Port to dtq-dev-767-base] Wrap long subject badges and show N/A for an empty file description - #1724
Merged
Conversation
…pty file description * fix(subject-badge): add text-wrap and text-left to prevent overflow (cherry picked from commit 5f5b9f4) * fix(file-description): display "N/A" when file description is empty (ufal/dspace-angular PR 167) * fix(file-description): display "N/A" when file description is empty * chore: apply review fixes - restore missing i18n keys and use robust test selectors * chore(i18n): restore blank lines in cs.json5 removed by sync-i18n Keep the key moves and new translations from the sync, but put back the blank-line separators so the diff only shows real changes. * chore(i18n): restore cs.json5 values mangled by sync-i18n on duplicate keys sync-i18n mixes up keys that appear twice in en.json5/cs.json5 and put the first Czech translation on the second (effective) entry. Restore the clarin-v7 values for admin.update-config.file-info.modified, admin.update-config.success.save.title and admin.update-config.error.save.message, and drop the bogus TODOs. --------- (cherry picked from commit 3eaf3f4) --------- (cherry picked from commit 7f16e81) Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz> Co-authored-by: amadulhaxxani <hassan@ufal.mff.cuni.cz> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
customer/lindat(commit 7f16e81), the same commit as PR 1698 fordtq-devDescription
Long subject badges on the item page wrap instead of overflowing. An empty file description shows "N/A" (CS "Neuvedeno").
Instructions for Reviewers
List of changes in this PR:
-x, no conflicts. The patch is identical to the source commit (samegit patch-id --stable).clarin-generic-item-field.component.html: the subject badge getstext-wrap text-left.file-description.component.htmlfalls back to the newitem.file.description.nakey, with a spec.cs.json5also carries ÚFAL's i18n sync from the same source commit: a few keys move,menu.section.icon.update_configis added with an English value and aTODO, and the Czech value ofadmin.update-config.help.allowed-files.descriptionis replaced by English with aTODO. Kept as in the source commit,dtq-devhas the same text.yarn run sync-i18nwas not run. Both i18n files still parse as JSON5.How to test: open an item with a long subject on a narrow screen, the badge wraps. Open an item whose file has no description, the preview shows "N/A".
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.🤖 Generated with Claude Code