Skip to content

[Port to dtq-dev-767-base] Wrap long subject badges and show N/A for an empty file description - #1724

Merged
milanmajchrak merged 1 commit into
dtq-dev-767-basefrom
767-base/fe-port-lindat-1686
Nov 10, 2026
Merged

milanmajchrak merged 1 commit into
dtq-dev-767-basefrom
767-base/fe-port-lindat-1686

Conversation

@milanmajchrak

@milanmajchrak milanmajchrak commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

References

  • Port of dataquest-dev/dspace-angular PR 1686 from customer/lindat (commit 7f16e81), the same commit as PR 1698 for dtq-dev
  • Originally ufal/dspace-angular PR 171 (issue 168) and PR 167 (issue 166)

Description

Long subject badges on the item page wrap instead of overflowing. An empty file description shows "N/A" (CS "Neuvedeno").

Instructions for Reviewers

List of changes in this PR:

  • Commit 7f16e81 cherry-picked with -x, no conflicts. The patch is identical to the source commit (same git patch-id --stable).
  • clarin-generic-item-field.component.html: the subject badge gets text-wrap text-left.
  • file-description.component.html falls back to the new item.file.description.na key, with a spec.
  • cs.json5 also carries ÚFAL's i18n sync from the same source commit: a few keys move, menu.section.icon.update_config is added with an English value and a TODO, and the Czech value of admin.update-config.help.allowed-files.description is replaced by English with a TODO. Kept as in the source commit, dtq-dev has the same text. yarn run sync-i18n was not run. Both i18n files still parse as JSON5.
  • Lint and specs were not run locally, they are left to CI.

How to test: open an item with a long subject on a narrow screen, the badge wraps. Open an item whose file has no description, the preview shows "N/A".

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

…pty file description

* fix(subject-badge): add text-wrap and text-left to prevent overflow

(cherry picked from commit 5f5b9f4)

* fix(file-description): display "N/A" when file description is empty (ufal/dspace-angular PR 167)

* fix(file-description): display "N/A" when file description is empty

* chore: apply review fixes - restore missing i18n keys and use robust test selectors

* chore(i18n): restore blank lines in cs.json5 removed by sync-i18n

Keep the key moves and new translations from the sync, but put back
the blank-line separators so the diff only shows real changes.

* chore(i18n): restore cs.json5 values mangled by sync-i18n on duplicate keys

sync-i18n mixes up keys that appear twice in en.json5/cs.json5 and put
the first Czech translation on the second (effective) entry. Restore
the clarin-v7 values for admin.update-config.file-info.modified,
admin.update-config.success.save.title and
admin.update-config.error.save.message, and drop the bogus TODOs.

---------

(cherry picked from commit 3eaf3f4)

---------

(cherry picked from commit 7f16e81)

Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
Co-authored-by: amadulhaxxani <hassan@ufal.mff.cuni.cz>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@milanmajchrak
milanmajchrak merged commit 9420a1e into dtq-dev-767-base Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant