Skip to content

[Port to dtq-dev-767-base] sourceversion.py: release tag base lindat - #1726

Draft
milanmajchrak wants to merge 1 commit into
dtq-dev-767-basefrom
767-base/fe-port-lindat-96c78a3
Draft

milanmajchrak wants to merge 1 commit into
dtq-dev-767-basefrom
767-base/fe-port-lindat-96c78a3

Conversation

@milanmajchrak

@milanmajchrak milanmajchrak commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

References

  • Port of commit 96c78a3 from customer/lindat (pushed directly, no PR)
  • Twin for dtq-dev: dataquest-dev/dspace-angular PR 1704, an open draft with the same notice
  • No issue.

Description

scripts/sourceversion.py sets RELEASE_TAG_BASE='lindat' instead of 'none'. The value builds the "Release link" in the generated version page.

Instructions for Reviewers

List of changes in this PR:

  • Not recommended to merge as it is. The script's own comment says the value "will be different on each branch". With lindat, builds from this branch show .../releases/tag/lindat-<yyyy.mm.>... links.
  • Commit 96c78a3 cherry-picked with -x, no conflicts. The file is byte-identical to the dtq-dev twin's branch.

How to test: python scripts/sourceversion.py <run-url-prefix> <run-id>. The release link starts with lindat-. Not run locally.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

🤖 Generated with Claude Code

(cherry picked from commit 96c78a3)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant