Repository navigation
CLARIN-DSpace v9/Keep the license label icon when it is edited without a new file - #1730
Merged
Merged
Conversation
The backend PUT replaces the icon with whatever the request sends, so leaving the icon out removed it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Editing a license label without choosing a new icon file removed the label's icon. The form now sends the current icon back, so the icon stays.
Instructions for Reviewers
List of changes in this PR:
editLicenseLabelsendsselectedLabel.iconwhen no new file is chosen and "Remove current icon" is not checked. Before, it sentundefined. The backend PUT sets the icon to whatever the request sends, so it storednull.The REST API returns the icon as a base64 string. On PUT, Jackson decodes the same string back to the same bytes, so sending it back does not change the icon.
How to test:
/licenses/manage-tableand pick a license label that has an icon.Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.🤖 Generated with Claude Code