Repository navigation
Refactor/tests #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor/tests
Are you sure you want to change the base?
Refactor/tests #518
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have never used the PULL_REQUEST_TEMPLATE.md, but could be useful to put PRs into context. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # NA | ||
|
|
||
| ## Instructions & checklist for PR author | ||
|
|
||
| ### Description of changes | ||
|
|
||
| \[Add descriptions of changes made\] | ||
|
|
||
| ### Refactor instructions | ||
|
|
||
| Replaced `x <- eval(parse(text = x.name), envir = parent.frame())` with | ||
| `x <- .loadServersideObject(x)` | ||
|
|
||
| If necessary, check the class of the object using `.checkClass()` | ||
|
|
||
| ### Testing instructions | ||
|
|
||
| Writen server-side unit tests for unhappy flow | ||
|
|
||
| Run `devtools::test(filter = "smk-|disc|arg")` and check it passes | ||
|
|
||
| Run `devtools::check(args = '--no-tests')` and check it passes (we run | ||
| tests separately to skip performance checks) | ||
|
|
||
| Run | ||
| [`devtools::build()`](https://devtools.r-lib.org/reference/build.html) | ||
| and check it builds without errors | ||
|
|
||
| ## Instructions & checklist for PR reviewers | ||
|
|
||
| Run `devtools::test(filter = "smk-|disc|arg")` and check it passes | ||
|
|
||
| Run `devtools::check(args = '--no-tests')` and check it passes (we run | ||
| tests separately to skip performance checks) | ||
|
|
||
| Run | ||
| [`devtools::build()`](https://devtools.r-lib.org/reference/build.html) | ||
| and check it builds without errors |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| pandoc: 3.1.3 | ||
| pkgdown: 2.2.0 | ||
| pandoc: 3.7.0.2 | ||
| pkgdown: 2.2.1 | ||
| pkgdown_sha: ~ | ||
| articles: {} | ||
| last_built: 2026-07-06T11:51Z | ||
| last_built: 2026-10-14T13:19Z |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this?