Skip to content

Refactor/tests - #721

Open
timcadman wants to merge 3 commits into
v7.0-devfrom
refactor/tests
Open

timcadman wants to merge 3 commits into
v7.0-devfrom
refactor/tests

Conversation

@timcadman

@timcadman timcadman commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What's changed

  • Add unit tests for unhappy path where object doesn't exist
  • Add unit tests for unhappy path where input object is of the wrong class
  • Fix bug where performance duration was hard-coded to 30 seconds
  • Remove Arjun copywrite header mistakenly added to tests which I wrote. I'm happy to leave this in if you'd prefer, as you did do all the reviews!

@timcadman
timcadman changed the base branch from v6.3.6-dev to v7.0-dev October 14, 2026 10:26
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
⏳ 4 of 5 checks reported so far
CheckResult
Devtools checks✅ passed
Code quality✅ 0 new findings (package total: 2015)
Armadillo unit tests✅ [ FAIL 0 | WARN 0 | SKIP 27 | PASS 12483 ]
Opal unit tests✅ [ FAIL 0 | WARN 0 | SKIP 27 | PASS 12445 ]
Test coverageℹ️ no coverable lines changed (project: 69.2%)

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.19%. Comparing base (903426d) to head (b5aabcd).

Additional details and impacted files
@@             Coverage Diff              @@
##           v7.0-dev     #721      +/-   ##
============================================
+ Coverage     68.93%   69.19%   +0.25%     
============================================
  Files           142      142              
  Lines          5788     5788              
============================================
+ Hits           3990     4005      +15     
+ Misses         1798     1783      -15     
Flag Coverage Δ
armadillo-arg 21.02% <ø> (ø)
armadillo-misc 15.65% <ø> (ø)
armadillo-perf-1 9.29% <ø> (ø)
armadillo-perf-2 17.82% <ø> (ø)
armadillo-perf-3 16.15% <ø> (ø)
armadillo-smk-1 35.27% <ø> (+0.24%) ⬆️
armadillo-smk-2 39.85% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timcadman
timcadman marked this pull request as draft October 16, 2026 06:59
@timcadman
timcadman removed the request for review from StuartWheater October 16, 2026 06:59
@timcadman
timcadman marked this pull request as ready for review October 16, 2026 08:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants