fix: Keep plugins working for logins from older versions - #295
Merged
Merged
Conversation
scotwells
force-pushed
the
fix/294-plugins-after-auth-switch
branch
from
September 25, 2026 17:12
765f552 to
bfd0fbd
Compare
scotwells
changed the title
scotwells
force-pushed
the
fix/294-plugins-after-auth-switch
branch
from
September 25, 2026 17:19
bfd0fbd to
3ddf991
Compare
scotwells
marked this pull request as ready for review
September 25, 2026 17:21
scotwells
enabled auto-merge
September 25, 2026 17:21
A user whose login predates the session config, and whose first command after upgrading is a plugin, got an empty API host, so the plugin could not reach Datum Cloud. Plugin setup now resolves the account the same way docs openapi and auth get-token do, which creates the missing session from the stored login. The switch test now stores credentials for the previous account, so it fails on the old code with that account's host rather than an empty one. Tests that build plugin settings start from an empty mock keyring so they never read a developer's real credentials. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
scotwells
force-pushed
the
fix/294-plugins-after-auth-switch
branch
from
September 25, 2026 17:22
3ddf991 to
d9ed2ad
Compare
ecv
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #293, a user whose login predates the session config, and whose first command after upgrading is a plugin, gets no API host and the plugin cannot reach Datum Cloud. Before #293 that case worked.
Plugin setup now looks up the account the same way
auth get-tokenanddocs openapido, which also creates the missing session from the stored login.Test plan
datumctl auth switch, plugin commands act as the switched-to accountRelated to #292
Fixes #294
🤖 Generated with Claude Code