fix: provision zones for domains pointed at Datum nameservers - #200
Merged
Merged
Conversation
The replicator holds a DNSZone back until its Domain is verified, but the Domain controller verifies by nameserver delegation only against a DNSZone that already has status.nameservers. Those were filled in only after the zone was provisioned, so a domain pointed at Datum could never verify and its zone never provisioned. markPendingDomainVerification now publishes the DNSZoneClass nameservers on a waiting zone without provisioning it. updateStatus no longer blanks them while the new downstream zone has yet to report its own. The static nameserver lookup moves to dnsutils.ClassNameservers so the replicator and the PowerDNS client share it.
mattdjenkinson
approved these changes
Sep 29, 2026
scotwells
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #100, a zone for a domain pointed at Datum nameservers never provisions, because its domain can't verify until the zone reports nameservers, and it only reported them once live. A zone waiting on verification now shows the nameservers from its class without being served, so delegating the domain to them verifies it.
Depends on datum-cloud/network-services-operator#519, which must roll out first.
Test plan