Repository navigation
fix: Keep a DNS name another record set owns when deleting - #217
Merged
Merged
Conversation
ecv
changed the title
ecv
force-pushed
the
fix/delete-keeps-other-owners
branch
from
October 3, 2026 02:09
2e5a632 to
15dce12
Compare
When two record sets of one type list the same name, the later writer replaces the RRset and leaves its own ownership comment. Deleting the earlier record set still removed every name in its spec, so the later record set's name stopped resolving while it kept reporting Programmed. Skip a spec-listed name whose ownership comment names another record set. A name with no ownership comment is still deleted, as before. Fixes #188
ecv
force-pushed
the
fix/delete-keeps-other-owners
branch
from
October 3, 2026 02:15
15dce12 to
fb11ed1
Compare
ecv
marked this pull request as ready for review
October 3, 2026 02:35
ecv
enabled auto-merge
October 3, 2026 02:35
Contributor
Author
|
pr-adversary verdict: merge, no findings. The new test passes at this head and fails on main. pr-conventions-reviewer verdict: hold, for a 57-character commit subject. The subject has since been shortened to 50 characters. Its other points were declined: the overlap with #111 is pre-existing (#111 already conflicts with main in client.go), and the human chose to ship this in the next normal release. Applied: the commit subject shortening, in the head commit. CI: all checks passed. Auto-merge is enabled with the merge method. The ruleset requires a code owner approval and approval of the last push, so this waits for a human approval. |
privateip
approved these changes
Oct 3, 2026
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
Summary
When two record sets of one type list the same name, the one that writes last owns it, but deleting the other record set removed the name anyway. The owner kept reporting the name as live while it stopped resolving. Deleting a record set now leaves a name another record set owns, and still removes names with no recorded owner. The owner does not re-check itself after the delete; one writer per zone (#201) closes that gap.
Test plan