Repository navigation
feat: Reject ALIAS records at wildcard names - #227
Merged
Merged
Conversation
PowerDNS expands an ALIAS only when the query name equals the record owner exactly, so an ALIAS at "*" or "*.app" was accepted and published but never resolved. Key changes: - Refuse an ALIAS record whose name has "*" as its first label on create and update, with a message pointing to CNAME - Keep a wildcard ALIAS already stored editable when an update does not add it, matching how held owner names are treated - Note the rule in the agent record-type guidance
scotwells
marked this pull request as ready for review
October 7, 2026 19:10
mattdjenkinson
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A wildcard ALIAS record used to be accepted and published but never resolved, because the DNS server only expands an ALIAS when the query name matches the record exactly. It is now rejected at write time with a message pointing to CNAME, which works at wildcards.
User experience
Before: this was accepted, and queries under
appnever resolved.After: the same object is rejected on create and update.
Unchanged: CNAME, A and AAAA at wildcards, and ALIAS at the apex (
@) or an exact name likewww. A wildcard ALIAS that is already stored stays editable on updates that do not add it; only newly added wildcard ALIAS names are refused.Test plan
*,*.appand an FQDN wildcard is rejected on create@andwww, are acceptedmake lintclean; webhook tests pass (the pdns integration tests need Docker and were not run)Fixes #226