Repository navigation
Keep transact-enterprise at its released version when testing the demo apps - #665
Merged
Merged
Conversation
…o apps The JVM demo apps now depend on dev.dbos:transact-enterprise (demo-apps #493). The demo-app job rewrites every dev.dbos coordinate to this build's version, but only this repository's artifacts are published at that version. transact-enterprise is built in the enterprise repository, so every app failed to resolve it, on every PR. The job now leaves transact-enterprise at the version the app names. The apps only load it when connecting to Conductor, which CI doesn't do. Gradle resolves its transitive dev.dbos:transact to this build's newer version.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the workflow change preserving the demo apps’ declared released transact-enterprise version.
No open issues 🎉
What changed in this PR
Updates the demo-app test workflow to keep transact-enterprise at the app’s declared released version, avoiding resolution failures for an artifact not published by this repository.
Changes:
- Excludes lines containing
transact-enterprisefrom dependency-version rewriting while retaining updates for other DBOS dependency lines. - Adds comments explaining why enterprise keeps its released version and is only loaded with Conductor.
| File | Description |
|---|---|
.github/workflows/test_demo_apps.yml |
Adjusts dependency rewriting to preserve the released enterprise version during demo-app tests. |
Review effort: Balanced
Keeping it at its released version did not work. transact-enterprise 1.3.0's Gradle metadata requires dev.dbos:transact strictly 1.3.0, so it cannot sit beside this build's transact, and resolution failed. The apps only need the enterprise artifact to connect to Conductor, when DBOS_CONDUCTOR_KEY is set. This job doesn't set it, so the dependency is removed from the build file under test, and the other dev.dbos coordinates are rewritten as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JVM demo apps now depend on
dev.dbos:transact-enterprise(dbos-demo-apps#493, merged 2026-11-13). Since then, everytest-demo-appsjob fails on every PR:The job rewrites every
dev.dboscoordinate in an app's build file to this build's version, but only this repository's artifacts are published to Maven Local at that version.transact-enterpriseis built in the enterprise repository.A released
transact-enterprisecan't be used instead. Its Gradle metadata requiresdev.dbos:transactstrictly at its own version (1.3.0 today), so it cannot sit beside this build'stransact; this PR's first commit tried that, and resolution failed.This change removes the
transact-enterprisedependency from the build file under test, and rewrites the otherdev.dboscoordinates as before. The apps only need the enterprise artifact to connect to Conductor, whenDBOS_CONDUCTOR_KEYis set, which this job doesn't do. No demo code imports it.A known gap that remains: these jobs don't test a core change together with an enterprise build. That needs this workflow to build the enterprise repository against the PR.
🤖 Generated with Claude Code